701253 - Switch partitioning cron job to use database function

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[[:jberkus] Josh Berkus]

This is actually lars's bug, but every time he files it, Bugzilla eats it.

I've written the database function Lars requested to control weekly partitioning of reports et. al.  It's documented on socorro-docs:

https://github.com/mozilla/socorro-docs/blob/master/docs/databaseadminfunctions.rst

Next step is for Lars to change the cron job to use this.

Comment 1

[[:jberkus] Josh Berkus]

Oh,the function is installed on DevDB.

Comment 3

[Laura Thomson :laura]

Lars likely to be out for 2.3.4 -> 2.4

Comment 4

[K Lars Lohn [:lars] [:klohn]]

this will be the 1st configman based cron app.

it should be built on the generic-app framework (see Bug 713769).

Comment 5

[Peter Bengtsson [:peterbe]]

Code "complete" https://github.com/mozilla/socorro/pull/281 and works but still needs some more tests for new lib code added. Haven't actually tested it manually but functional tests assures it calls the stored procedure.

Comment 6

[[:jberkus] Josh Berkus]

OK, I should retest the stored procedure, given that it may not match the current schema.  Will do.

Comment 7

[[:jberkus] Josh Berkus]

Checked the stored procedure, works fine.  Is already installed on prod, so no deployment necessary.

Comment 8

[Peter Bengtsson [:peterbe]]

Code landed in master here:
https://github.com/mozilla/socorro/commit/def1a68d194c66f95c21e41971f3d549ae874040

How it works is documented here:
http://socorro.readthedocs.org/en/latest/generic_app.html

Remaining is:
* bug721134 - installing configman from submodule into /usr/lib/python/site-packages/...
* potentially a different way of starting this and all cron script (work in progress by lonnen)
* actual parameters shouldn't come from commonconfig. This works fine for testing but this should ideally soon be replaced with something better.

Comment 9

[Peter Bengtsson [:peterbe]]

Landed. Just now depending on the installation of configman in production.

Comment 10

[Peter Bengtsson [:peterbe]]

This is now resolved as fixed as configman is correctly installed in production. 

But don't we also need to actually execute the new cron script? I.e. socorro/cron/weeklyReportsPartitions.py

Who can wire that up? Who knows how often this should be executed?