Closed Bug 701260 Opened 9 years ago Closed 9 years ago

Deny requests for DOM full-screen when windowed plugins are present in the entire doc tree

Categories

(Core :: DOM: Core & HTML, defect)

10 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10
Tracking Status
firefox10 --- fixed
firefox11 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

(Whiteboard: [inbound][qa?])

Attachments

(1 file)

Currently the check which prevents us going full-screen when a doctree contains a windowed plugin only checks the document and its subdocuments, whereas it should check every document in the target document's branch (but not in other branches/tabs).
Attached patch PatchSplinter Review
Change to deny requests for full-screen if any doc in the tab has a windowed plugin, rather than if the requesting doc or its subdocs have windowed plugins.

I have tests, but the tests leak on tryserver (even without this patch applied!), so I'll not put the tests up for review.
Assignee: nobody → chris
Status: NEW → ASSIGNED
Attachment #574747 - Flags: review?(roc)
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d6b8636246
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/67d6b8636246
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 574747 [details] [diff] [review]
Patch

Requesting approval for Aurora, because this fix prevents a work-around which enables keyboard input in full-screen mode which doesn't cause the "Press ESC to leave full-screen mode" warning to pop up. We need this to help protect against phishing attacks.
Attachment #574747 - Flags: approval-mozilla-aurora?
Comment on attachment 574747 [details] [diff] [review]
Patch

[triage comment]
Approved for aurora. Please land as soon as possible
Attachment #574747 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is this something QA can verify?
Whiteboard: [inbound] → [inbound][qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #7)
> Is this something QA can verify?

bump
You need to log in before you can comment on or make changes to this bug.