The default bug view has changed. See this FAQ.

Deny requests for DOM full-screen when windowed plugins are present in the entire doc tree

RESOLVED FIXED in Firefox 10

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

10 Branch
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox10 fixed, firefox11 fixed)

Details

(Whiteboard: [inbound][qa?])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Currently the check which prevents us going full-screen when a doctree contains a windowed plugin only checks the document and its subdocuments, whereas it should check every document in the target document's branch (but not in other branches/tabs).
(Assignee)

Comment 1

5 years ago
Created attachment 574747 [details] [diff] [review]
Patch

Change to deny requests for full-screen if any doc in the tab has a windowed plugin, rather than if the requesting doc or its subdocs have windowed plugins.

I have tests, but the tests leak on tryserver (even without this patch applied!), so I'll not put the tests up for review.
Assignee: nobody → chris
Status: NEW → ASSIGNED
Attachment #574747 - Flags: review?(roc)
Attachment #574747 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d6b8636246
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/67d6b8636246
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
status-firefox10: --- → affected
status-firefox11: --- → fixed
(Assignee)

Comment 4

5 years ago
Comment on attachment 574747 [details] [diff] [review]
Patch

Requesting approval for Aurora, because this fix prevents a work-around which enables keyboard input in full-screen mode which doesn't cause the "Press ESC to leave full-screen mode" warning to pop up. We need this to help protect against phishing attacks.
Attachment #574747 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
Comment on attachment 574747 [details] [diff] [review]
Patch

[triage comment]
Approved for aurora. Please land as soon as possible
Attachment #574747 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/43e4a46ca7dc
status-firefox10: affected → fixed
Target Milestone: mozilla11 → mozilla10
Is this something QA can verify?
Whiteboard: [inbound] → [inbound][qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #7)
> Is this something QA can verify?

bump
You need to log in before you can comment on or make changes to this bug.