No favicons display after loading pages

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
9 months ago

People

(Reporter: mfinkle, Assigned: Margaret)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment)

Since the layers panning and zooming code landed, I no longer see favicons being loaded/displayed in the URL bar. I do see the favicon messages in logcat, letting me know the favicon was discovered.

Updated

6 years ago
Assignee: nobody → margaret.leibovic
Priority: -- → P1
(Assignee)

Comment 1

6 years ago
Created attachment 573680 [details] [diff] [review]
patch

A JSONException is getting thrown because the DOMContentLoaded event doesn't have a pageSize property. This meant that handleContentLoaded is never getting called, and that's where loadFavicon is called. jsonPageSize isn't even being used anywhere, so I just removed this line.

Asking Patrick for review since this was introduced by https://hg.mozilla.org/projects/birch/rev/eaf778e88070.
Attachment #573680 - Flags: review?(pwalton)
Comment on attachment 573680 [details] [diff] [review]
patch

Doh, good catch.
Attachment #573680 - Flags: review?(pwalton) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/projects/birch/rev/e65b9655e3e8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
20111111100727
http://hg.mozilla.org/projects/birch/rev/e65b9655e3e8
(Samsung Galaxy SII Android 2.3.4)
Status: RESOLVED → VERIFIED
OS: Linux → Android
Hardware: x86 → ARM
(Reporter)

Updated

6 years ago
Duplicate of this bug: 701801
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.