701285 - No favicons display after loading pages

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Since the layers panning and zooming code landed, I no longer see favicons being loaded/displayed in the URL bar. I do see the favicon messages in logcat, letting me know the favicon was discovered.

Comment 1

[:Margaret Leibovic]

Attachment: patch

A JSONException is getting thrown because the DOMContentLoaded event doesn't have a pageSize property. This meant that handleContentLoaded is never getting called, and that's where loadFavicon is called. jsonPageSize isn't even being used anywhere, so I just removed this line.

Asking Patrick for review since this was introduced by https://hg.mozilla.org/projects/birch/rev/eaf778e88070.

Comment 2

[Patrick Walton (:pcwalton)]

Comment on attachment 573680 [details] [diff] [review]
patch

Doh, good catch.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/projects/birch/rev/e65b9655e3e8

Comment 4

[Aaron Train [:aaronmt]]

20111111100727
http://hg.mozilla.org/projects/birch/rev/e65b9655e3e8
(Samsung Galaxy SII Android 2.3.4)