701421 - NotifyIconObservers doesn't set icon on redirected bookmarks in some case

Status: NEW

(Toolkit :: Places, defect, P3)

Description

[Marco Bonardo [:mak]]

NotifyIconObservers does not update redirected bookmarks if:

1) the icon didn't change or was not associated to a page. This may be acceptable though as a perf win, since the issue would happen if I add a bookmark redirecting to a page that already has a valid icon. Pretty edge case, also, after the icon expires (1 week), it would be updated, unless it falls into case 2.

2) there is also a bookmark pointing to the final page, so this one wins over the redirected one.

For example having a bookmark to http://www.mozilla.org/en-US/firefox/central/ and a bookmark to http://www.mozilla.com/en-US/firefox/central/, loading the second bookmark will redirect to the .org page, but won't update the bookmark's icon for the .com page.

This looks like a bug that exists from quite some time, I'd say from FF4.
Both of these are edge cases.