Closed
Bug 701467
Opened 14 years ago
Closed 14 years ago
Remove JS_TRUE/JS_FALSE from xpconnect
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(3 files)
|
788 bytes,
text/plain
|
Details | |
|
305.84 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
|
5.33 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
As requested
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
Generated with attachment 573593 [details].
Attachment #573594 -
Flags: review?(bobbyholley+bmo)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #573595 -
Flags: review?(bobbyholley+bmo)
|
||
Comment 4•14 years ago
|
||
Comment on attachment 573594 [details] [diff] [review]
Part a: replace JS_TRUE/JS_FALSE with true/false
Looks good!
Please wait a few days before landing this so that tracer removal (bug 698201) can land, as so that we can make sure that write barriers doesn't need a backout.
r=bholley on this patch and any minor rebases required given the above.
Attachment #573594 -
Flags: review?(bobbyholley+bmo) → review+
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 573595 [details] [diff] [review]
Part b: Reindent macro continuations
r=bholley.
Attachment #573595 -
Flags: review?(bobbyholley+bmo) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Landed the two of them together:
https://hg.mozilla.org/mozilla-central/rev/3258ba3a269d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•