Last Comment Bug 701467 - Remove JS_TRUE/JS_FALSE from xpconnect
: Remove JS_TRUE/JS_FALSE from xpconnect
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-10 12:07 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-11-26 07:32 PST (History)
1 user (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Script (788 bytes, text/plain)
2011-11-10 12:08 PST, :Ms2ger (⌚ UTC+1/+2)
no flags Details
Part a: replace JS_TRUE/JS_FALSE with true/false (305.84 KB, patch)
2011-11-10 12:10 PST, :Ms2ger (⌚ UTC+1/+2)
bobbyholley: review+
Details | Diff | Splinter Review
Part b: Reindent macro continuations (5.33 KB, patch)
2011-11-10 12:10 PST, :Ms2ger (⌚ UTC+1/+2)
bobbyholley: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-11-10 12:07:13 PST
As requested
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-11-10 12:08:59 PST
Created attachment 573593 [details]
Script
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-11-10 12:10:06 PST
Created attachment 573594 [details] [diff] [review]
Part a: replace JS_TRUE/JS_FALSE with true/false

Generated with attachment 573593 [details].
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-11-10 12:10:44 PST
Created attachment 573595 [details] [diff] [review]
Part b: Reindent macro continuations
Comment 4 Bobby Holley (:bholley) (busy with Stylo) 2011-11-10 16:32:56 PST
Comment on attachment 573594 [details] [diff] [review]
Part a: replace JS_TRUE/JS_FALSE with true/false

Looks good!

Please wait a few days before landing this so that tracer removal (bug 698201) can land, as so that we can make sure that write barriers doesn't need a backout.

r=bholley on this patch and any minor rebases required given the above.
Comment 5 Bobby Holley (:bholley) (busy with Stylo) 2011-11-10 16:34:00 PST
Comment on attachment 573595 [details] [diff] [review]
Part b: Reindent macro continuations

r=bholley.
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2011-11-26 07:32:24 PST
Landed the two of them together:

https://hg.mozilla.org/mozilla-central/rev/3258ba3a269d

Note You need to log in before you can comment on or make changes to this bug.