The default bug view has changed. See this FAQ.

IonMonkey: Incorrect result from CallGeneric on x64

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
This is failing jit-tests/tests/ion/bug670484.js on IM TBPL, x64 only, with --ion --ion-eager --ion-gvn=off. It might be a register allocation bug:

      9 callgeneric ([x:9 (=rcx)]) (=rdx) t=([p:7 (=rbp)], [p:8 (=rbx)]) <|@
      0 movegroup ()[=rax -> =rcx] <|@
      10 return () (=rcx) <|@

This movegroup looks bad - it clobbers the outgoing return register with something bogus.
(Assignee)

Updated

5 years ago
Duplicate of this bug: 701554
(Assignee)

Comment 2

5 years ago
Created attachment 573707 [details] [diff] [review]
fix

My fault. I botched JSClobberMask last week.
Assignee: general → dvander
Status: NEW → ASSIGNED
Attachment #573707 - Flags: review?(sstangl)

Updated

5 years ago
Attachment #573707 - Flags: review?(sstangl) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/736d52cc985c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Created attachment 573877 [details] [diff] [review]
Fix typo in previous fix typo.
Attachment #573877 - Flags: review?(sstangl)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

5 years ago
Attachment #573877 - Flags: review?(sstangl) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/ab790991e91f
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.