Closed
Bug 701523
Opened 13 years ago
Closed 13 years ago
Make loading script actors optional in DebuggerServer.init()
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.38 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
In Marionette (https://wiki.mozilla.org/Auto-tools/Projects/Marionette), we utilize the DebuggerServer, but we don't want or need the script actors. This patch makes loading the script actors conditional on an extra argument passed to init.
Attachment #573639 -
Flags: review?(dcamp)
|
||
Comment 1•13 years ago
|
||
It seems that you don't need the nested event loop helper either, just the transport handling and socket manipulation parts. In that case it looks cleaner to me to have an initTransport or similar that would cater to your needs and have init call that for the script debugger case.
This patch also breaks DebuggerServer.initialized for other users besides Marionette.
|
Reporter | |
Comment 2•13 years ago
|
||
New patch which addresses comments.
Attachment #573639 -
Attachment is obsolete: true
Attachment #573639 -
Flags: review?(dcamp)
Attachment #573858 -
Flags: review?(dcamp)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 573858 [details] [diff] [review]
DebuggerServer.init patch, v0.2
Review of attachment 573858 [details] [diff] [review]:
-----------------------------------------------------------------
OK to land on remote-debug.
Attachment #573858 -
Flags: review?(dcamp) → review+
|
|
Reporter | |
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•