Last Comment Bug 701523 - Make loading script actors optional in DebuggerServer.init()
: Make loading script actors optional in DebuggerServer.init()
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: 697762
  Show dependency treegraph
 
Reported: 2011-11-10 14:16 PST by Jonathan Griffin (:jgriffin)
Modified: 2011-11-15 17:20 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
DebuggerServer.init patch (5.02 KB, patch)
2011-11-10 14:16 PST, Jonathan Griffin (:jgriffin)
no flags Details | Diff | Review
DebuggerServer.init patch, v0.2 (1.38 KB, patch)
2011-11-11 11:13 PST, Jonathan Griffin (:jgriffin)
dcamp: review+
Details | Diff | Review

Description Jonathan Griffin (:jgriffin) 2011-11-10 14:16:08 PST
Created attachment 573639 [details] [diff] [review]
DebuggerServer.init patch

In Marionette (https://wiki.mozilla.org/Auto-tools/Projects/Marionette), we utilize the DebuggerServer, but we don't want or need the script actors.  This patch makes loading the script actors conditional on an extra argument passed to init.
Comment 1 Panos Astithas [:past] 2011-11-11 08:01:30 PST
It seems that you don't need the nested event loop helper either, just the transport handling and socket manipulation parts. In that case it looks cleaner to me to have an initTransport or similar that would cater to your needs and have init call that for the script debugger case.

This patch also breaks DebuggerServer.initialized for other users besides Marionette.
Comment 2 Jonathan Griffin (:jgriffin) 2011-11-11 11:13:48 PST
Created attachment 573858 [details] [diff] [review]
DebuggerServer.init patch, v0.2

New patch which addresses comments.
Comment 3 Dave Camp (:dcamp) 2011-11-15 14:12:48 PST
Comment on attachment 573858 [details] [diff] [review]
DebuggerServer.init patch, v0.2

Review of attachment 573858 [details] [diff] [review]:
-----------------------------------------------------------------

OK to land on remote-debug.
Comment 4 Jonathan Griffin (:jgriffin) 2011-11-15 17:20:11 PST
Landed as http://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/c0498cb305de

Note You need to log in before you can comment on or make changes to this bug.