701523 - Make loading script actors optional in DebuggerServer.init()

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

Attachment: DebuggerServer.init patch

In Marionette (https://wiki.mozilla.org/Auto-tools/Projects/Marionette), we utilize the DebuggerServer, but we don't want or need the script actors.  This patch makes loading the script actors conditional on an extra argument passed to init.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

It seems that you don't need the nested event loop helper either, just the transport handling and socket manipulation parts. In that case it looks cleaner to me to have an initTransport or similar that would cater to your needs and have init call that for the script debugger case.

This patch also breaks DebuggerServer.initialized for other users besides Marionette.

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: DebuggerServer.init patch, v0.2

New patch which addresses comments.

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 573858 [details] [diff] [review]
DebuggerServer.init patch, v0.2

Review of attachment 573858 [details] [diff] [review]:
-----------------------------------------------------------------

OK to land on remote-debug.

Comment 4

[Jonathan Griffin (:jgriffin)]

Landed as http://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/c0498cb305de