The default bug view has changed. See this FAQ.

Make loading script actors optional in DebuggerServer.init()

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 573639 [details] [diff] [review]
DebuggerServer.init patch

In Marionette (https://wiki.mozilla.org/Auto-tools/Projects/Marionette), we utilize the DebuggerServer, but we don't want or need the script actors.  This patch makes loading the script actors conditional on an extra argument passed to init.
Attachment #573639 - Flags: review?(dcamp)
It seems that you don't need the nested event loop helper either, just the transport handling and socket manipulation parts. In that case it looks cleaner to me to have an initTransport or similar that would cater to your needs and have init call that for the script debugger case.

This patch also breaks DebuggerServer.initialized for other users besides Marionette.
(Reporter)

Comment 2

5 years ago
Created attachment 573858 [details] [diff] [review]
DebuggerServer.init patch, v0.2

New patch which addresses comments.
Attachment #573639 - Attachment is obsolete: true
Attachment #573639 - Flags: review?(dcamp)
Attachment #573858 - Flags: review?(dcamp)

Comment 3

5 years ago
Comment on attachment 573858 [details] [diff] [review]
DebuggerServer.init patch, v0.2

Review of attachment 573858 [details] [diff] [review]:
-----------------------------------------------------------------

OK to land on remote-debug.
Attachment #573858 - Flags: review?(dcamp) → review+
(Reporter)

Comment 4

5 years ago
Landed as http://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/c0498cb305de
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.