Closed
Bug 701581
Opened 14 years ago
Closed 14 years ago
test-httpd.js shouldn't do test.pass() and test.done() at the end of the test.
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KWierso, Unassigned)
Details
Attachments
(1 file)
|
382 bytes,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
That causes the console to say that it passed 2 of 2 tests, when there's really only one test being run.
This patch drops test.pass(), so only test.done() is left.
Attachment #573701 -
Flags: review?(myk)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 573701 [details] [diff] [review]
Drop test.pass()
A few issues, a few nits, all noted in the pull request.
Attachment #573701 -
Flags: review?(myk) → review-
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 573701 [details] [diff] [review]
Drop test.pass()
Erm, that last comment was meant for a different bug. This looks great, r=myk.
Attachment #573701 -
Flags: review- → review+
|
||
Comment 3•14 years ago
|
||
Commit pushed to https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/f982a3b604233833df822da01be118cbcff1c7ae
fix bug 701581 - test-httpd.js shouldn't do test.pass() and test.done() at the end of the test; r=myk
|
|
||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•