Last Comment Bug 701628 - Remove _COMPILER_PREFIX
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
-- trivial (vote)
: mozilla11
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
Blocks: 724700
  Show dependency treegraph
Reported: 2011-11-10 22:40 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-02-06 15:16 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (8.65 KB, patch)
2011-11-10 22:40 PST, Jeff Walden [:Waldo] (remove +bmo to email)
ted: review+
Details | Diff | Splinter Review

Description User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-11-10 22:40:07 PST
Created attachment 573753 [details] [diff] [review]

This variable is always empty, so clearly it's not needed.  It clutters up the warnings flags list creation code -- let's remove it and make things more readable.

I noticed this while doing the recent Clang warnings stuff, considered adding it in there, then decided better to have a separate bug for it.
Comment 1 User image Ted Mielczarek [:ted.mielczarek] 2011-11-11 04:31:12 PST
Comment on attachment 573753 [details] [diff] [review]

Review of attachment 573753 [details] [diff] [review]:

Thanks, I was wondering what that was for when reviewing your other patch. Clearly some historical artifact at this point.
Comment 2 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-11-11 14:33:07 PST
Comment 3 User image Ed Morley [:emorley] 2011-11-12 04:52:03 PST

Note You need to log in before you can comment on or make changes to this bug.