Closed Bug 701655 Opened 13 years ago Closed 11 years ago

Have some sort of reward for landing a changeset which gets a full set of green tests

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: Dolske)

Details

Attachments

(4 files)

Trophies. Let me show you them.
246.38 KB, image/jpeg
Details
First winner (jgilbert)
242.10 KB, image/jpeg
Details
Second winner (khuey)
55.71 KB, image/jpeg
Details
Third winner (MattN)
340.01 KB, image/jpeg
Details
It's so uncommon these days to land and not have some random orange/purple/blue etc. occur.... so there should be a reward of some description for winning the TBPL lottery. Like beers, or Mozilla swag.
And we may have a first winner, Luke Wagner! https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=71046de4fb6a Now just to figure out the number of points for the collection and the prize :)
I think as an additional set of difficulties, the changesets should also get pgo (luke has been double lucky here)
ahi ahi ahi, Luke gets disqualified for a M4 orange on winxp pgo, sorry!
(In reply to Marco Bonardo [:mak] from comment #1) \o/ (In reply to Marco Bonardo [:mak] from comment #3) Q_Q
\o/
I have a (limited) supply of trophies for when this happens. Limit 1 per committer. Must be claimed in person in MV office. Offer subject to change at any time.
Not under the current bug summary, which claims the winner is the committer. Sometimes committer-as-winner makes sense (thinking mostly of merges, or perhaps for people who land half a dozen checkin-needed patches at once), but more often I think the patch author is the proper person to credit. What's anyone say to making it the person who committed the change *and/or* a person who wrote all the patches in it? (I'm not saying this is necessarily the absolute best and most precise description of who "should" win, just a better one.)
Given that it's all a game of chance anyways, splitting hairs over who wins seems silly.
True enough, but I'd rather not speak for Dolske in comment 8. :-)
I still haven't had anyone come by asking for their trophy. :( They are waiting! I'll open this up to any folks not in MV. (Trophies may not arrive in time for Xmas, though.)
But then, didn't the wise men who up a bit late with their gifts?
I, uhh, guess I own this bug now!
Assignee: nobody → dolske
(In reply to Justin Dolske [:Dolske] from comment #13) > Created attachment 581505 [details] > Trophies. Let me show you them. > > I still haven't had anyone come by asking for their trophy. :( I'm not in the US
(In reply to Justin Dolske [:Dolske] from comment #13) > Created attachment 581505 [details] > Trophies. Let me show you them. hey, they are nice!
(In reply to Marco Bonardo [:mak] from comment #5) > Mike Hommey could win! > https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=109b2416d243 Android Opt is busted (red) on that changeset. Unless that tree was hidden at the time, it's unfortunately ineligible for the "full set of green tests".
I had an all-green build a few months ago. It got backed out for causing oranges. (It was later suspected as a source of some suddenly much more frequent oranges. philor retriggered a bunch of the tests. They all went orange. Repeatedly. Backout. I later re-landed with no problems -- well, other than the usual array of random oranges.)
(In reply to Justin Dolske [:Dolske] from comment #18) > (In reply to Marco Bonardo [:mak] from comment #5) > > Mike Hommey could win! > > https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=109b2416d243 > > Android Opt is busted (red) on that changeset. Unless that tree was hidden > at the time, it's unfortunately ineligible for the "full set of green tests". That's from November 17th, birch merged to mozilla-central and made it possible to build native Fennec on December 6th, so having a green one back then would have called for more than just a trophy.
Attached image First winner (jgilbert) —
(In reply to Matt Brubeck (:mbrubeck) from comment #7) > jgilbert is our next winner! > https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=9c20e88fe6c1 Congrats to Jeff, the first to successfully claim his trophy! 5 more left!
No winners since December? :(
khuey's push has some blue in it, but I think it should count: https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=6323a689d6f1
Congratulations khuey! Please stop by to claim your trophy and have your picture taken. 3 more left! (one has been re-purposed, first come first-serve!) Also, the commits in comment 9 and comment 5 (per comment 20) seem eligible to me. Guess I missed these in my bugmail. So, congrats to glandium and dmandelin! Come claim your trophies too! [glandium: Since uptake has been slow, happy to mail yours out if you're not going to be in MV soon. You may alternatively donate to someone local as a nagging reminder of their inability to perform an all-green push. ;)]
Attached image Second winner (khuey) —
Finally claimed!
No talos or PGO, but close enough? https://tbpl.mozilla.org/?tree=Try&rev=e72260647793
Attached image Third winner (MattN) —
Hoooooooly crap. We have another winner! Congrats to Matt! https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ed82d3fb789c (The orange M3 on 10.8-opt was hidden at the time)
A winner! No Android tests, but whatever. https://tbpl.mozilla.org/?tree=Fx-Team&rev=cdda582f86ce
(In reply to Geoff Lankow (:darktrojan) from comment #33) > A winner! No Android tests, but whatever. > > https://tbpl.mozilla.org/?tree=Fx-Team&rev=cdda582f86ce It's not like we even run half our android tests, anyways. :P We should sponsor an x-prize for getting Ceder green.
No one has claimed one recently, so closing as fixed for the first 3 recipients.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: