Closed Bug 701716 Opened 9 years ago Closed 9 years ago

navigator.vibrate Android backend is missing an AutoLocalJNIFrame.

Categories

(Core :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11
Tracking Status
firefox10 --- affected
firefox11 --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

Filing this as a separate bug from bug 679966 since it requires us to modify code which is currently in the tree.

The following code causes Fennec to crash

while(true) {
  navigator.mozVibrate([100, 100]);
}

W/dalvikvm(16350): ReferenceTable overflow (max=512)
W/dalvikvm(16350): Last 10 entries in JNI local reference table:
W/dalvikvm(16350):   502: 0x40612028 cls=[J (44 bytes)
W/dalvikvm(16350):   503: 0x40612360 cls=[J (44 bytes)
W/dalvikvm(16350):   504: 0x40612698 cls=[J (44 bytes)
... and so on

The problem is a missing AutoLocalJNIFrame in AndroidBridge.
Attached patch Patch v1Splinter Review
I'll add a test to the DOM implementation in bug 679966.
Comment on attachment 573810 [details] [diff] [review]
Patch v1

Strangely enough, I had do do a full clobber for this change to have any effect.
Attachment #573810 - Flags: review?(mwu)
This should land in Aurora unless we back out bug 679966.  I'd prefer to back it out and have an outstanding backout request in the bug.
Attachment #573810 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/f3411e7e4bc1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.