701716 - navigator.vibrate Android backend is missing an AutoLocalJNIFrame.

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

Filing this as a separate bug from bug 679966 since it requires us to modify code which is currently in the tree.

The following code causes Fennec to crash

while(true) {
  navigator.mozVibrate([100, 100]);
}

W/dalvikvm(16350): ReferenceTable overflow (max=512)
W/dalvikvm(16350): Last 10 entries in JNI local reference table:
W/dalvikvm(16350):   502: 0x40612028 cls=[J (44 bytes)
W/dalvikvm(16350):   503: 0x40612360 cls=[J (44 bytes)
W/dalvikvm(16350):   504: 0x40612698 cls=[J (44 bytes)
... and so on

The problem is a missing AutoLocalJNIFrame in AndroidBridge.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

I'll add a test to the DOM implementation in bug 679966.

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 573810 [details] [diff] [review]
Patch v1

Strangely enough, I had do do a full clobber for this change to have any effect.

Comment 3

[Justin Lebar (not reading bugmail)]

This should land in Aurora unless we back out bug 679966.  I'd prefer to back it out and have an outstanding backout request in the bug.

Comment 4

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3411e7e4bc1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f3411e7e4bc1