navigator.vibrate Android backend is missing an AutoLocalJNIFrame.

RESOLVED FIXED in Firefox 11

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
mozilla11
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox10 affected, firefox11 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Filing this as a separate bug from bug 679966 since it requires us to modify code which is currently in the tree.

The following code causes Fennec to crash

while(true) {
  navigator.mozVibrate([100, 100]);
}

W/dalvikvm(16350): ReferenceTable overflow (max=512)
W/dalvikvm(16350): Last 10 entries in JNI local reference table:
W/dalvikvm(16350):   502: 0x40612028 cls=[J (44 bytes)
W/dalvikvm(16350):   503: 0x40612360 cls=[J (44 bytes)
W/dalvikvm(16350):   504: 0x40612698 cls=[J (44 bytes)
... and so on

The problem is a missing AutoLocalJNIFrame in AndroidBridge.
(Assignee)

Comment 1

6 years ago
Created attachment 573810 [details] [diff] [review]
Patch v1

I'll add a test to the DOM implementation in bug 679966.
(Assignee)

Comment 2

6 years ago
Comment on attachment 573810 [details] [diff] [review]
Patch v1

Strangely enough, I had do do a full clobber for this change to have any effect.
Attachment #573810 - Flags: review?(mwu)
(Assignee)

Comment 3

6 years ago
This should land in Aurora unless we back out bug 679966.  I'd prefer to back it out and have an outstanding backout request in the bug.
status-firefox10: --- → affected
status-firefox11: --- → affected

Updated

6 years ago
Attachment #573810 - Flags: review?(mwu) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3411e7e4bc1
Assignee: nobody → justin.lebar+bug
status-firefox11: affected → fixed

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/f3411e7e4bc1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.