Closed Bug 701839 Opened 8 years ago Closed 8 years ago

Wrong favicon displayed when both default location and link exists

Categories

(Firefox for Android :: General, defect, P3)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: davehunt, Assigned: bnicholson)

References

()

Details

(Whiteboard: [testday-20111111])

Attachments

(1 file)

I noticed that the favicon for a Google Code project is using the default favicon for the domain instead of the one specified by the <link> tag.

Steps to reproduce:
1. Open http://code.google.com/p/selenium/

Expected result:
Favicon displayed in awesomebar should be http://www.gstatic.com/codesite/ph/images/phosting.ico

Actual result:
Favicon displayed in awesomebar is http://code.google.com/favicon.ico
Assignee: nobody → sriram
Assignee: sriram → bnicholson
Confirmed on Android 3.1  (Samsung Galaxy Tab 10.1);
and Android 3.2  (Asus Transformer)
What's more I'm seeing a new issue where content is not actually shown when surfing to the above page.  Entered as:

https://bugzilla.mozilla.org/show_bug.cgi?id=701906
Priority: -- → P3
Attached patch patchSplinter Review
It looks like the issue may be caused by this Android bug: http://code.google.com/p/android/issues/detail?id=6066

This patch fully downloads the image before creating a Drawable.
Attachment #574431 - Flags: review?(mark.finkle)
Attachment #574431 - Attachment filename: bug_701906.patch → bug_701839.patch
Comment on attachment 574431 [details] [diff] [review]
patch

Brian, were you able to reproduce the issue and then see this patch fix it?

r+ if we are sure this was the cause and it's fixed now.
Attachment #574431 - Flags: review?(mark.finkle) → review+
Yes; Drawable.createFromStream() was returning null for me (and preventing this specific favicon from loading).  After changing the code to download the entire image first, the favicon loads as expected.
Landed http://hg.mozilla.org/projects/birch/rev/3394b9626828
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111117 Firefox/11.0a1 Fennec/11.0a1
Device: Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
Sorry, this is the actual build:
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111120 Firefox/11.0a1 Fennec/11.0a1
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.