Failure in testSearch::testGetMoreSearchEngines.js



Mozilla QA
Mozmill Tests
6 years ago
5 years ago


(Reporter: ashughes, Assigned: RemusPop)


Bug Flags:
in-litmus +

Firefox Tracking Flags

(firefox12 fixed, firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox-esr10 fixed)


(Whiteboard: [mozmill-test-failure][qa-], URL)


(2 attachments, 1 obsolete attachment)

MODULE: tests/functional/testSearch/testGetMoreSearchEngines.js
TEST: testGetMoreEngines
FAIL: TimeoutError("Modal dialog has been found and processed")@resource://mozmill/modules/utils.js:429 waitFor([object Proxy],"Modal dialog has been found and processed",30000,100,[object Proxy])@resource://mozmill/modules/utils.js:467 
BRANCH: mozilla-release, mozilla-beta, mozilla-aurora, default


6 years ago
Assignee: nobody → remus.pop

Comment 1

6 years ago
The only fail closer to this is the waitForPageLoad error. I cannot reproduce the other one.
Anyway the cause for this would likely be no response from the network when we click the Add to Firefox button. If this would be the case, the solution lies in installing a search engine from localhost.
Any other info would be appreciated.
This should be tested on qa-horus if it can't be reproduced locally. Does it happen all the time? Only for the daily testrun or also when the test module or the folder gets executed? Which platforms are affected? This information I kinda miss in the initial comments all over the place now. :/

Comment 3

6 years ago
Last week (11th to 18th of November) only one fail occured for this test: 
* controller.waitForPageLoad(): Timeout waiting for page loaded
which I mentioned earlier.
I'm only seeing 2 instances of this failure in the last week. Once on 10.0a2 and another time with 8.0.1. I'm thinking this is most likely due to a connectivity glitch.

Resolving WONTFIX for now. We can reopen if this starts happening much more frequently.
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
Reopening this due to failure in the 9.0b5 testruns today:

This only happened once and given the history of this bug I think it's safe to say this is a very intermittent failure.

Remus, please submit a patch to disable this test immediately. It is unreliable in it's current form and will likely need to be refactored.
Resolution: WONTFIX → ---
Created attachment 580054 [details] [diff] [review]
patch v1.0

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #5)
> Remus, please submit a patch to disable this test immediately. It is
> unreliable in it's current form and will likely need to be refactored.
Remus had some work with other tests. Seeing as this was marked as "immediately", I took the liberty of skipping it. Hope it's ok.
Assignee: remus.pop → alex.lakatos
Attachment #580054 - Flags: review?(
Attachment #580054 - Flags: review?( → review+
Created attachment 580096 [details] [diff] [review]
disable test (default/aurora/beta) [checked-in]

Your commit message is backwards -- please use the correct format. I've uploaded a corrected patch.
Attachment #580054 - Attachment is obsolete: true
Attachment #580096 - Flags: review+
Summary: Failure in testGetMoreSearchEngines.js: Modal dialog has been found and processed → Failure in testSearch::testGetMoreSearchEngines.js
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
Comment on attachment 580096 [details] [diff] [review]
disable test (default/aurora/beta) [checked-in]

Landed: (default) (mozilla-aurora) (mozilla-beta)
Attachment #580096 - Attachment description: disable test (default/aurora/beta) → disable test (default/aurora/beta) [checked-in]

Comment 9

5 years ago
No failures for this one, so here are the reports from the testruns:




I will follow up with a patch to enable the test.

Comment 10

5 years ago
Created attachment 625048 [details] [diff] [review]
enable test v1 (all branches) [checked-in]

This enables the test.
Attachment #625048 - Flags: review?(dave.hunt)
Remus: Could you resubmit results for Linux? The test is skipped in the report you've linked to in comment 9. Once I've seen that it's passing I can r+ this and land it.
Assignee: alex.lakatos → remus.pop

Comment 12

5 years ago
It seems I may forgot to qrefresh before the testrun. So here are the new results. testGetMoreSearchEngines is included.

Comment 13

5 years ago
Thanks Remus. Landed as:

Once we have this passing we can transplant it to the remaining branches.
status-firefox-esr10: --- → affected
status-firefox12: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → fixed
Last Resolved: 6 years ago5 years ago
Resolution: --- → FIXED
Landed as: (mozilla-aurora) (mozilla-beta) (mozilla-release) (mozilla-esr10)

Remus: I just noticed that you set the reviewer as dave.hunt. Please use dhunt when I am the reviewer in the future.
status-firefox-esr10: affected → fixed
status-firefox12: affected → fixed
status-firefox13: affected → fixed
status-firefox14: affected → fixed
Yay! So lets now get the appropriate Litmus tests updated (if necessary).
Flags: in-litmus?(remus.pop)
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]

Comment 17

5 years ago
Dave: wrote it down.

Here are the links from Litmus for this test:



Flags: in-litmus?(remus.pop) → in-litmus+
This also needs an update of the 10.0 Litmus test.
Flags: in-litmus+ → in-litmus?(remus.pop)

Comment 19

5 years ago
Missed it. 
Firefox ESR (10.0):


5 years ago
Flags: in-litmus?(remus.pop) → in-litmus+
Comment on attachment 625048 [details] [diff] [review]
enable test v1 (all branches) [checked-in]

Missed setting the r+ when I landed this.
Attachment #625048 - Flags: review?(dave.hunt) → review+


5 years ago
Attachment #625048 - Attachment description: enable test v1 (all branches) → enable test v1 (all branches) [checked-in]
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][qa-]
You need to log in before you can comment on or make changes to this bug.