The default bug view has changed. See this FAQ.

Element FullScreen API should hide Sidebar

RESOLVED FIXED in Firefox 11

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Alice0775 White, Assigned: cpearce)

Tracking

Trunk
Firefox 11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 574011 [details]
sample html

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/1374294a6119
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111111 Firefox/11.0a1 ID:20111111031514

Element FullScreen API should hide Sidebar

Reproducible: Always

Steps to Reproduce:
1 Start Firefox with clean profile
2 Open sample html
3 Open Sidebar (Ctrl+B)
4 Click "full" button


Actual Results:
  Sidebar would not be hidden.


Expected Results:
  Sidebar shoould be hidden.
(Assignee)

Comment 1

5 years ago
Created attachment 577823 [details] [diff] [review]
Patch v1

Hide the sidebar when entering DOM full-screen mode.
Assignee: nobody → chris
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #577823 - Flags: review?(dao)
Comment on attachment 577823 [details] [diff] [review]
Patch v1

patch doesn't apply on mozilla-central tip
Attachment #577823 - Flags: review?(dao)
(Assignee)

Comment 3

5 years ago
Created attachment 578049 [details] [diff] [review]
Patch v1 rebased

Rebased.
Attachment #577823 - Attachment is obsolete: true
Attachment #578049 - Flags: review?(dao)
Comment on attachment 578049 [details] [diff] [review]
Patch v1 rebased

This seems to do strange things when the sidebar isn't actually open...

Warning: Empty string passed to getElementById().
Source File: chrome://browser/content/browser.xul
Line: 0

Error: sidebarBroadcaster is null
Source File: chrome://browser/content/browser.js
Line: 8656
Attachment #578049 - Flags: review?(dao) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 578955 [details] [diff] [review]
Patch v2
Attachment #578049 - Attachment is obsolete: true
Attachment #578955 - Flags: review?(dao)
Like the first patch, this one doesn't apply cleanly again.
Component: Toolbars → General
QA Contact: toolbars → general
(Assignee)

Comment 7

5 years ago
Created attachment 578966 [details] [diff] [review]
Patch v2 rebased
Attachment #578955 - Attachment is obsolete: true
Attachment #578955 - Flags: review?(dao)
Attachment #578966 - Flags: review?(dao)
Comment on attachment 578966 [details] [diff] [review]
Patch v2 rebased

This leaves the side bar splitter on screen (and trying to reopen the side bar just hides the splitter)
Attachment #578966 - Flags: review?(dao) → review-
(Assignee)

Comment 9

5 years ago
Created attachment 579195 [details] [diff] [review]
Patch v3
Attachment #578966 - Attachment is obsolete: true
Attachment #579195 - Flags: review?(dao)

Updated

5 years ago
Attachment #579195 - Flags: review?(dao) → review+

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/21150b624407
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/21150b624407
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
I have created bug 701992 since the sidebar is not restored when exiting fullscreen.

I am not sure if this is intentional, as seems to be the case with the find bar here http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3959
copy paste error, I created Bug 714675
(Reporter)

Updated

5 years ago
Depends on: 714675
You need to log in before you can comment on or make changes to this bug.