Closed Bug 701992 Opened 10 years ago Closed 10 years ago
Screen API should hide Sidebar
Build Identifier: http://hg.mozilla.org/mozilla-central/rev/1374294a6119 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111111 Firefox/11.0a1 ID:20111111031514 Element FullScreen API should hide Sidebar Reproducible: Always Steps to Reproduce: 1 Start Firefox with clean profile 2 Open sample html 3 Open Sidebar (Ctrl+B) 4 Click "full" button Actual Results: Sidebar would not be hidden. Expected Results: Sidebar shoould be hidden.
Hide the sidebar when entering DOM full-screen mode.
Assignee: nobody → chris
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 577823 [details] [diff] [review] Patch v1 patch doesn't apply on mozilla-central tip
Comment on attachment 578049 [details] [diff] [review] Patch v1 rebased This seems to do strange things when the sidebar isn't actually open... Warning: Empty string passed to getElementById(). Source File: chrome://browser/content/browser.xul Line: 0 Error: sidebarBroadcaster is null Source File: chrome://browser/content/browser.js Line: 8656
Attachment #578049 - Flags: review?(dao) → review-
Like the first patch, this one doesn't apply cleanly again.
Component: Toolbars → General
QA Contact: toolbars → general
Comment on attachment 578966 [details] [diff] [review] Patch v2 rebased This leaves the side bar splitter on screen (and trying to reopen the side bar just hides the splitter)
Attachment #578966 - Flags: review?(dao) → review-
Target Milestone: --- → Firefox 11
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
I have created bug 701992 since the sidebar is not restored when exiting fullscreen. I am not sure if this is intentional, as seems to be the case with the find bar here http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3959
copy paste error, I created Bug 714675
You need to log in before you can comment on or make changes to this bug.