Tab counter animation should show overlapping of numbers

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
9 months ago

People

(Reporter: sriram, Assigned: sriram)

Tracking

unspecified
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
As per the UI spec, the tab counter animation should show overlapping of numbers.
(Assignee)

Comment 1

6 years ago
Created attachment 574013 [details] [diff] [review]
Patch

I tried re-implementing TextSwitcher as a Odometer. This moves all the logic to a new file and does the overlap.
The magic was in setting the amount to displace (currently 30%) :sigh: :( :(
Assignee: nobody → sriram
Attachment #574013 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

6 years ago
Created attachment 574014 [details] [diff] [review]
Patch

If "the amount to displace" was the "magic" for showing a overlap, I was wondering if that would work with TextSwitcher also.

Strangely it does!! :(
After 2 hours of working on the previous patch, I figured out it takes just 4 line change in existing code to achieve the same effect! :big-sigh: :(
Attachment #574014 - Flags: review?(mark.finkle)
(Assignee)

Updated

6 years ago
OS: Mac OS X → Android
Hardware: x86 → All
Attachment #574013 - Attachment is obsolete: true
Attachment #574013 - Flags: review?(mark.finkle)
Attachment #574014 - Flags: review?(mark.finkle) → review+
Priority: -- → P3
https://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Neat.

Sririam, did you file a bug for tweaking the animation speed?

20111115040200
http://hg.mozilla.org/projects/birch/rev/97283e503e1e
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.