702064 - <Down Arrow> key doesn't scroll down on page (quora.com)

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect)

Description

[alex_mayorga]

STR:
Load http://www.quora.com/Whats-the-best-way-to-escape-the-police-in-a-high-speed-car-chase
Press <Down Arrow> key

Result:
Page doesn't scroll

Expected result:
Page scrolls down

Comment 1

[ffextensionguru]

Duplicate results and the browser will stop responding for a second or two while the page loads. Windows 32 & 64-Bit Nightly.

Comment 2

[Alice0775 White]

Regression window(m-c),
Works:
http://hg.mozilla.org/mozilla-central/rev/9ad06a6f7fb4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 ID:20111025093145
Fails:
http://hg.mozilla.org/mozilla-central/rev/f2fa4ae74ee1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 ID:20111025102146
Pushlog
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9ad06a6f7fb4&tochange=f2fa4ae74ee1
Regressed by:
f2fa4ae74ee1	Olli Pettay — Bug 696020, target key events to html:body, r=bz+enn

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

This looks like a evang bug.

Ben, do you happen to know what causes this?

Comment 4

[alex_mayorga]

Maybe related http://www.quora.com/Why-doesnt-the-page-down-key-work-on-Quora-answer-pages-in-Firefox-3-6?

Comment 5

[j.j.]

Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101 Firefox/9.0.1

Hmm, this works for me. However, it works only after the pages has loaded completely and that takes some time.

Comment 6

[Alex Keybl [:akeybl]]

(In reply to Olli Pettay [:smaug] from comment #3)
> This looks like a evang bug.
> 
> Ben, do you happen to know what causes this?

Olli - given the changed behavior regression range, do you still believe this to be a tech evangelism bug? If so, please CC Jean-Yves Perrier and Kev to help with outreach.

Comment 7

[Alice0775 White]

(In reply to j.j. from comment #5)
> Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
> 
> Hmm, this works for me. However, it works only after the pages has loaded
> completely and that takes some time.

Tis is not for Firefox9.0

Comment 8

[Alice0775 White]

Fortunately, I cannot reproduce in Nightly12.0a1.

Fixed window:
Cannot scroll:
http://hg.mozilla.org/mozilla-central/rev/ede336ccaed0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20111223 Firefox/12.0a1 ID:20111223155718
Can scroll:
http://hg.mozilla.org/mozilla-central/rev/4d0391866459
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20111223 Firefox/12.0a1 ID:20111223161318
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ede336ccaed0&tochange=4d0391866459

Fixed by:
4d0391866459	Neil Rashbrook — Bug 669026 Fix caret movement when contenteditable areas are present r=ehsan

Comment 9

[(no longer active)]

quora.com  does indeed use a contenteditable field for their comments box.

Comment 10

[Alex Keybl [:akeybl]]

Do we have a workaround for quora.com or a smaller low-risk fix that we could uplift to Aurora 10 and Beta 11? It sounds like both of those versions (and possibly a number of sites) are still affected by this bug.

I'd like to keep this bug open to continue discussion around the exacerbated effects in FF10, and how to move forward.

Comment 11

[[e-mail]]

(In reply to Alex Keybl from comment #10)
> Do we have a workaround for quora.com or a smaller low-risk fix that we
> could uplift to Aurora 10 and Beta 11? It sounds like both of those versions
> (and possibly a number of sites) are still affected by this bug.
There is no way to have a lower-risk fix. The workaround is for quora.com to use a designMode frame rather than a contenteditable element.

Comment 12

[Alex Keybl [:akeybl]]

(In reply to [e-mail] from comment #11)
> (In reply to Alex Keybl from comment #10)
> > Do we have a workaround for quora.com or a smaller low-risk fix that we
> > could uplift to Aurora 10 and Beta 11? It sounds like both of those versions
> > (and possibly a number of sites) are still affected by this bug.
> There is no way to have a lower-risk fix. The workaround is for quora.com to
> use a designMode frame rather than a contenteditable element.

https://bugzilla.mozilla.org/show_bug.cgi?id=702064#c2 seems to imply that this could be mitigated by backing out bug 696020, but I think that has more value than downside.

Sending over to Tech Evangelism to suggest the use of designMode. Also untracking since we haven't heard of other fallout.

Comment 13

[(no longer active)]

(In reply to Alex Keybl [:akeybl] from comment #12)
> (In reply to [e-mail] from comment #11)
> > (In reply to Alex Keybl from comment #10)
> > > Do we have a workaround for quora.com or a smaller low-risk fix that we
> > > could uplift to Aurora 10 and Beta 11? It sounds like both of those versions
> > > (and possibly a number of sites) are still affected by this bug.
> > There is no way to have a lower-risk fix. The workaround is for quora.com to
> > use a designMode frame rather than a contenteditable element.
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=702064#c2 seems to imply that
> this could be mitigated by backing out bug 696020, but I think that has more
> value than downside.

This is a question that smaug can answer...

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

We certainly can't back out bug 696020 without backing out also bug 689564 and bug 659350.

Comment 15

[alex_mayorga]

I can't reproduce this anymore on Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:12.0a1) Gecko/20120112 Firefox/12.0a1 ID:20120112031044

FWIW a Quora employee seems to be listening at http://www.quora.com/Why-do-the-page-up-and-page-down-keys-sometimes-not-work-on-Quora-with-Firefox/answer/Marc-Bodnick

Comment 16

[Ben Newman (:bnewman) (:benjamn)]

Hey folks, sorry to be so late to see this.

In case you're curious, the workaround I implemented for Quora was to add key event listeners to the input field corresponding to the up/down/page-up/page-down/space/shift-space keystrokes, and, if the input field is empty, scroll the page using window.scrollBy, and blur the input field.

I would love to be evangelized regarding these designMode frames, though. Is there some more documentation anywhere about good rich text editing practices that I could read?

Comment 17

[(no longer active)]

(In reply to Ben Newman (:bnewman) (:benjamn) from comment #16)
> I would love to be evangelized regarding these designMode frames, though. Is

It's really simple, something like this should work:

<iframe src="data:text/html," id="x">
<script>
var iframe = document.getElementById("x");
iframe.contentDocument.designMode = "on";
// whenever you need to grab the text which the user has typed:
var text = iframe.contentDocument.body.textContent;
</script>

> there some more documentation anywhere about good rich text editing
> practices that I could read?

Unfortunately not.  But feel free to ask questions if you have them.  :-)

Comment 18

[(no longer active)]

Regarding docs, while this is not about good practices, it might be a good start: <https://developer.mozilla.org/en/Rich-Text_Editing_in_Mozilla>

Comment 19

[Karl Dubost💡 :karlcow]

CLosing as WORKSFORME.
Tested in Firefox 32.0.3 clean profile.