Use IDL for nsIDOMWindowUtils::GetParent

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 574153 [details] [diff] [review]
Patch v1

dom/base/nsDOMWindowUtils.cpp             |  56 +++++++++++++-------------------------------------------
 dom/interfaces/base/nsIDOMWindowUtils.idl |   2 +-
 2 files changed, 14 insertions(+), 44 deletions(-)
Attachment #574153 - Flags: review?(bzbarsky)

Comment 1

6 years ago
Comment on attachment 574153 [details] [diff] [review]
Patch v1

I believe the new code does the wrong thing if |parent| is non-null but has no outerObject hook.

Also, should the argument there really be JS::Value and not jsval?
Attachment #574153 - Flags: review?(bzbarsky) → review-
(Assignee)

Comment 2

6 years ago
Created attachment 574386 [details] [diff] [review]
Patch v2

Er, yes.

jsval is a typedef for JS::Value now, and has the slight advantage that you only need to include jspubtd.h to refer to it while you need jsapi.h to use jsval. Not that that doesn't make any difference here.
Attachment #574153 - Attachment is obsolete: true
Attachment #574386 - Flags: review?(bzbarsky)

Comment 3

6 years ago
Comment on attachment 574386 [details] [diff] [review]
Patch v2

r=me; nice to see all that gunk go away.
Attachment #574386 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/56ed0304e5de
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.