Last Comment Bug 702118 - Use IDL for nsIDOMWindowUtils::GetParent
: Use IDL for nsIDOMWindowUtils::GetParent
Status: RESOLVED FIXED
[qa-]
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-13 06:51 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-11-16 10:32 PST (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (3.33 KB, patch)
2011-11-13 06:51 PST, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review-
Details | Diff | Splinter Review
Patch v2 (3.32 KB, patch)
2011-11-14 13:02 PST, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-11-13 06:51:10 PST
Created attachment 574153 [details] [diff] [review]
Patch v1

dom/base/nsDOMWindowUtils.cpp             |  56 +++++++++++++-------------------------------------------
 dom/interfaces/base/nsIDOMWindowUtils.idl |   2 +-
 2 files changed, 14 insertions(+), 44 deletions(-)
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2011-11-14 12:07:47 PST
Comment on attachment 574153 [details] [diff] [review]
Patch v1

I believe the new code does the wrong thing if |parent| is non-null but has no outerObject hook.

Also, should the argument there really be JS::Value and not jsval?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-11-14 13:02:28 PST
Created attachment 574386 [details] [diff] [review]
Patch v2

Er, yes.

jsval is a typedef for JS::Value now, and has the slight advantage that you only need to include jspubtd.h to refer to it while you need jsapi.h to use jsval. Not that that doesn't make any difference here.
Comment 3 Boris Zbarsky [:bz] (still a bit busy) 2011-11-14 15:51:04 PST
Comment on attachment 574386 [details] [diff] [review]
Patch v2

r=me; nice to see all that gunk go away.
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-11-16 10:32:28 PST
https://hg.mozilla.org/mozilla-central/rev/56ed0304e5de

Note You need to log in before you can comment on or make changes to this bug.