702118 - Use IDL for nsIDOMWindowUtils::GetParent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

dom/base/nsDOMWindowUtils.cpp             |  56 +++++++++++++-------------------------------------------
 dom/interfaces/base/nsIDOMWindowUtils.idl |   2 +-
 2 files changed, 14 insertions(+), 44 deletions(-)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 574153 [details] [diff] [review]
Patch v1

I believe the new code does the wrong thing if |parent| is non-null but has no outerObject hook.

Also, should the argument there really be JS::Value and not jsval?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Er, yes.

jsval is a typedef for JS::Value now, and has the slight advantage that you only need to include jspubtd.h to refer to it while you need jsapi.h to use jsval. Not that that doesn't make any difference here.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 574386 [details] [diff] [review]
Patch v2

r=me; nice to see all that gunk go away.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/56ed0304e5de