Closed
Bug 702118
Opened 13 years ago
Closed 13 years ago
Use IDL for nsIDOMWindowUtils::GetParent
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
3.32 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
dom/base/nsDOMWindowUtils.cpp | 56 +++++++++++++-------------------------------------------
dom/interfaces/base/nsIDOMWindowUtils.idl | 2 +-
2 files changed, 14 insertions(+), 44 deletions(-)
Attachment #574153 -
Flags: review?(bzbarsky)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 574153 [details] [diff] [review]
Patch v1
I believe the new code does the wrong thing if |parent| is non-null but has no outerObject hook.
Also, should the argument there really be JS::Value and not jsval?
Attachment #574153 -
Flags: review?(bzbarsky) → review-
|
Assignee | |
Comment 2•13 years ago
|
||
Er, yes.
jsval is a typedef for JS::Value now, and has the slight advantage that you only need to include jspubtd.h to refer to it while you need jsapi.h to use jsval. Not that that doesn't make any difference here.
Attachment #574153 -
Attachment is obsolete: true
Attachment #574386 -
Flags: review?(bzbarsky)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 574386 [details] [diff] [review]
Patch v2
r=me; nice to see all that gunk go away.
Attachment #574386 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•