702167 - Sporadic TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug371576-1.html | Wrong order of execution - got ABEF, expected ABCDEF

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=7377708&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound debug test mochitests-1/5 on 2011-11-13 14:56:52 PST for push 7ff1026f9880
{
9112 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug371576-1.html | Wrong order of execution - got ABEF, expected ABCDEF
}

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Henri has been poking at parser stuff a lot lately. Could this be a regression from that?

Comment 2

[Henri Sivonen (:hsivonen)]

This test has been bogus (by depending on a race condition) ever since bug 591981 got fixed. I'm surprised this hadn't gone orange sooner. I think the test should be removed, since there's no obvious way to change the test to make sense in the HTML5-compliant world.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

So do we have tests that ensure that script execution happen in the correct order for both inline and DOM-inserted scripts? And that that order doesn't get messed up if someone sets innerHTML?

Comment 4

[Legacy TBPL/Treeherder Robot]

mbrubeck%mozilla.com
https://tbpl.mozilla.org/php/getParsedLog.php?id=7983109&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound opt test mochitests-1/5 on 2011-12-16 09:58:38

9124 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug371576-1.html | Wrong order of execution - got ABEF, expected ABCDEF

Comment 5

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=8180685&tree=Firefox
Rev3 WINNT 5.1 mozilla-central pgo test mochitests-1/5 on 2011-12-27 15:16:05

9124 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug371576-1.html | Wrong order of execution - got ABEF, expected ABCDEF

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to Jonas Sicking (:sicking) from comment #3)
> So do we have tests that ensure that script execution happen in the correct
> order for both inline and DOM-inserted scripts?

There's no "right" order for DOM-inserted scripts. That's why this test should be removed from the tree.

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: Remove the test

The test expect script-inserted scripts to have a deterministic execution order relative to parser-inserted scripts. The premise of the test is wrong per HTML5. See http://hsivonen.iki.fi/script-execution/

There's nothing to replace the test with, because the execution order is non-deterministic by spec.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 588397 [details] [diff] [review]
Remove the test

rs=me

Comment 9

[Henri Sivonen (:hsivonen)]

Thanks.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0153a4156538

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/0153a4156538