Last Comment Bug 702225 - Implement revised nav bar button appearance on Windows
: Implement revised nav bar button appearance on Windows
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
: -- enhancement (vote)
: Firefox 13
Assigned To: Dão Gottwald [:dao]
:
: Dão Gottwald [:dao]
Mentors:
Depends on:
Blocks: 694287 734373
  Show dependency treegraph
 
Reported: 2011-11-14 03:27 PST by Dão Gottwald [:dao]
Modified: 2012-03-16 01:21 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (9.36 KB, patch)
2011-11-14 03:27 PST, Dão Gottwald [:dao]
shorlander: review+
Details | Diff | Splinter Review

Comment 1 PimpUigi 2011-12-20 13:32:45 PST
Anyway I can look at this???
Comment 2 Dão Gottwald [:dao] 2012-02-17 04:25:03 PST
Stephen, could you please review this? It's ok if textures, borders etc. aren't quite perfect, as we can easily tweak them (about to happen in bug 727650).
Comment 3 Stephen Horlander [:shorlander] 2012-02-20 11:57:38 PST
(In reply to Dão Gottwald [:dao] from comment #2)
> Stephen, could you please review this? It's ok if textures, borders etc.
> aren't quite perfect, as we can easily tweak them (about to happen in bug
> 727650).

Yes! I will review this right now. Really sorry for the delay I have no idea how this fell off my radar.
Comment 4 Stephen Horlander [:shorlander] 2012-02-20 21:13:49 PST
Comment on attachment 574270 [details] [diff] [review]
patch

Review of attachment 574270 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Dão Gottwald [:dao] from comment #2)
> Stephen, could you please review this? It's ok if textures, borders etc.
> aren't quite perfect, as we can easily tweak them (about to happen in bug
> 727650).

Looks good! 

The only thing I noticed was that the #forward-button mask works on hover but distorts when pressed: http://cl.ly/1G2Z1i1F2B412r053344

Maybe fix it the same way as the hover/non-hover states?

>+  box-shadow: 0 1px 0 rgba(255,255,255,.3) inset,
>+              0 0 0 1px rgba(255,255,255,.3) inset,
>+              0 1px 0 hsla(210,54%,20%,.02),
>+              /* allows winstripe-keyhole-forward-mask to be used for non-hover as well as hover: */
>+              0 0 2px hsla(210,54%,20%,0);

+  box-shadow: 0 1px 1px rgba(0,0,0,.1) inset,
+              0 0 2px rgba(0,0,0,.3) inset,
+              /* allows winstripe-keyhole-forward-mask to be used for active as well as non-hover and hover: */
+              0 1px 0 hsla(210,54%,20%,0),
+              0 0 2px hsla(210,54%,20%,0);
Comment 5 Dão Gottwald [:dao] 2012-02-21 02:27:46 PST
> The only thing I noticed was that the #forward-button mask works on hover
> but distorts when pressed: http://cl.ly/1G2Z1i1F2B412r053344
> 
> Maybe fix it the same way as the hover/non-hover states?
> 
> >+  box-shadow: 0 1px 0 rgba(255,255,255,.3) inset,
> >+              0 0 0 1px rgba(255,255,255,.3) inset,
> >+              0 1px 0 hsla(210,54%,20%,.02),
> >+              /* allows winstripe-keyhole-forward-mask to be used for non-hover as well as hover: */
> >+              0 0 2px hsla(210,54%,20%,0);
> 
> +  box-shadow: 0 1px 1px rgba(0,0,0,.1) inset,
> +              0 0 2px rgba(0,0,0,.3) inset,
> +              /* allows winstripe-keyhole-forward-mask to be used for
> active as well as non-hover and hover: */
> +              0 1px 0 hsla(210,54%,20%,0),
> +              0 0 2px hsla(210,54%,20%,0);

done

http://hg.mozilla.org/integration/mozilla-inbound/rev/8bca9af04102
Comment 6 Ed Morley [:emorley] 2012-02-22 04:42:56 PST
https://hg.mozilla.org/mozilla-central/rev/8bca9af04102
Comment 7 Siddhartha Dugar [:sdrocking] 2012-02-22 07:23:59 PST
@Dao: Is there a bug filed for the Panorama button becoming white with dark personas when on the navigation toolbar (with large icon mode and tabs on top)?

Note You need to log in before you can comment on or make changes to this bug.