Closed Bug 702334 Opened 13 years ago Closed 13 years ago

Fix deadlocks caused by Flash

Categories

(Firefox for Android Graveyard :: General, defect, P1)

ARM
Android
defect

Tracking

(firefox11 fixed, fennec11+)

RESOLVED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(1 file)

Gecko does a synchronous round trip to request the plugin surface from the main Android thread. This deadlocks frequently. We should just make it asynchronous, since it's not imperative that the plugin is displayed on the very first paint.
Assignee: nobody → snorp
Attachment #574334 - Flags: review?(blassey.bugs)
Priority: -- → P1
Comment on attachment 574334 [details] [diff] [review]
Request java plugin surface asynchronously (and other small fixes)

Review of attachment 574334 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/base/nsNPAPIPluginInstance.h
@@ +49,4 @@
>  #include "nsIChannel.h"
>  #include "nsInterfaceHashtable.h"
>  #include "nsHashKeys.h"
> +#include "nsIRunnable.h"

put this in a #ifdef ANDROID
Attachment #574334 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/projects/birch/rev/924e2318089c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.