702368 - Disable the hang monitor for ts_places_generated_max

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Benjamin Smedberg]

The ts_places_generated_max test is triggering the hang detector (bug 492592). Since we aren't going to have a short-term fix for this issue, for now we should just disable the hang monitor for this test.

Per jmaher, we'll have to do this for all of the places dirty tests, since we can't set prefs for ts_places_generated_max and not ts_places_generated_med.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

in config.py, we need to change:

    'dirty': {
        'enable_by_default': True,
        'suites': GRAPH_CONFIG + ['--activeTests', 'ts_places_generated_med:ts_places_generated_max'],
        'options': (TALOS_DIRTY_OPTS, ALL_PLATFORMS),
    },


to be:
    'dirty': {
        'enable_by_default': True,
        'suites': GRAPH_CONFIG + ['--activeTests', 'ts_places_generated_med:ts_places_generated_max', '--setPref', 'hangdetector.timeout=0'],
        'options': (TALOS_DIRTY_OPTS, ALL_PLATFORMS),
    },

once talos has support for custom prefs/testcase we can remove this and move the change into the sample.config file.

we have a need to deploy a new talos.zip and change config.py as well in bug 702351, can we get these deployed this week?

Comment 2

[Benjamin Smedberg]

I gave jmaher bad info on IRC, the pref name should be "hangmonitor.timeout" instead of "hangdetector..."

Comment 3

[Armen [:armenzg]]

Attachment: add hangdetector.timeout=0 to dirty talos jobs

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 574373 [details] [diff] [review]
add hangdetector.timeout=0 to dirty talos jobs

Review of attachment 574373 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ +163,5 @@
>          'options': ({}, ALL_PLATFORMS),
>      },
>      'dirty': {
>          'enable_by_default': True,
> +        'suites': GRAPH_CONFIG + ['--activeTests', 'ts_places_generated_med:ts_places_generated_max', '--setPref', 'hangdetector.timeout=0'],

please make this 'hangmonitor.timeout=0', I had some wrong information and was corrected in comment 2, otherwise this looks great.

Comment 5

[Armen [:armenzg]]

Attachment: add hangmonitor.timeout=0 to dirty talos jobs

I landed this as hangmonitor.

Waiting for a reconfigure for this to be picked up.

Comment 6

[Armen [:armenzg]]

http://hg.mozilla.org/build/buildbot-configs/rev/de95039dd5b1

Comment 7

[Armen [:armenzg]]

Reconfigs have been prevented yesterday and today due to the releases going on.

Comment 8

[Aki Sasaki (not active)]

This landed in this morning's reconfig.

Comment 9

[Armen [:armenzg]]

This is live as per this morning's reconfig.