Rule view shouldn't update during highlighting

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Developer Tools
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

10 Branch
Firefox 14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [computedview][ruleview])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
It needs to respect the highlighter's dim state.
This also goes for the computed view. The rule view updates and does not dim ... the style inspector does not update but does not dim. Ideally both tools should not update and should dim.
Whiteboard: [computedview][ruleview]
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All

Updated

5 years ago
Depends on: 707809
(Assignee)

Updated

5 years ago
Assignee: nobody → dcamp

Comment 2

5 years ago
With bug 707809, the Rule View and the Computed View don't update anymore while inspecting. We just need a placeholder when there's nothing to show.
(Assignee)

Comment 3

5 years ago
Created attachment 615509 [details] [diff] [review]
Empty placeholder

Adds a placeholder that matches the computed view's placeholder.
Attachment #615509 - Flags: review?(paul)
Comment on attachment 615509 [details] [diff] [review]
Empty placeholder

+  _showEmpty: function CssRuleView_showEmpty()
+  {
+    if (this.element.querySelectorAll("#noResults").length > 0) {

or even just if ...getElementById("noResults") ... ?

no real need for qSA.
Attachment #615509 - Flags: review?(paul) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/ac3ea3b31fe0
Whiteboard: [computedview][ruleview] → [computedview][ruleview][fixed-in-fx-team]
(Assignee)

Comment 6

5 years ago
I did switch to getElementById().
https://hg.mozilla.org/mozilla-central/rev/ac3ea3b31fe0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [computedview][ruleview][fixed-in-fx-team] → [computedview][ruleview]
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.