Last Comment Bug 702411 - Rule view shouldn't update during highlighting
: Rule view shouldn't update during highlighting
Status: RESOLVED FIXED
[computedview][ruleview]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: 10 Branch
: All All
P2 normal (vote)
: Firefox 14
Assigned To: Dave Camp (:dcamp)
:
: J. Ryan Stinnett [:jryans] (use ni?)
Mentors:
Depends on: 707809
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-14 13:20 PST by Dave Camp (:dcamp)
Modified: 2012-04-20 02:00 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Empty placeholder (4.18 KB, patch)
2012-04-16 15:41 PDT, Dave Camp (:dcamp)
rcampbell: review+
Details | Diff | Splinter Review

Description User image Dave Camp (:dcamp) 2011-11-14 13:20:22 PST
It needs to respect the highlighter's dim state.
Comment 1 User image PTO - Michael Ratcliffe [:miker] [:mratcliffe] 2012-01-11 06:10:32 PST
This also goes for the computed view. The rule view updates and does not dim ... the style inspector does not update but does not dim. Ideally both tools should not update and should dim.
Comment 2 User image Paul Rouget [:paul] 2012-04-04 04:43:21 PDT
With bug 707809, the Rule View and the Computed View don't update anymore while inspecting. We just need a placeholder when there's nothing to show.
Comment 3 User image Dave Camp (:dcamp) 2012-04-16 15:41:54 PDT
Created attachment 615509 [details] [diff] [review]
Empty placeholder

Adds a placeholder that matches the computed view's placeholder.
Comment 4 User image Rob Campbell [:rc] (:robcee) 2012-04-18 11:59:21 PDT
Comment on attachment 615509 [details] [diff] [review]
Empty placeholder

+  _showEmpty: function CssRuleView_showEmpty()
+  {
+    if (this.element.querySelectorAll("#noResults").length > 0) {

or even just if ...getElementById("noResults") ... ?

no real need for qSA.
Comment 6 User image Dave Camp (:dcamp) 2012-04-19 12:05:43 PDT
I did switch to getElementById().
Comment 7 User image Tim Taubert [:ttaubert] 2012-04-20 02:00:29 PDT
https://hg.mozilla.org/mozilla-central/rev/ac3ea3b31fe0

Note You need to log in before you can comment on or make changes to this bug.