Closed Bug 702411 Opened 13 years ago Closed 12 years ago

Rule view shouldn't update during highlighting

Categories

(DevTools :: General, defect, P2)

10 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 14

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

(Whiteboard: [computedview][ruleview])

Attachments

(1 file)

It needs to respect the highlighter's dim state.
This also goes for the computed view. The rule view updates and does not dim ... the style inspector does not update but does not dim. Ideally both tools should not update and should dim.
Whiteboard: [computedview][ruleview]
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Depends on: 707809
Assignee: nobody → dcamp
With bug 707809, the Rule View and the Computed View don't update anymore while inspecting. We just need a placeholder when there's nothing to show.
Adds a placeholder that matches the computed view's placeholder.
Attachment #615509 - Flags: review?(paul)
Comment on attachment 615509 [details] [diff] [review]
Empty placeholder

+  _showEmpty: function CssRuleView_showEmpty()
+  {
+    if (this.element.querySelectorAll("#noResults").length > 0) {

or even just if ...getElementById("noResults") ... ?

no real need for qSA.
Attachment #615509 - Flags: review?(paul) → review+
https://hg.mozilla.org/integration/fx-team/rev/ac3ea3b31fe0
Whiteboard: [computedview][ruleview] → [computedview][ruleview][fixed-in-fx-team]
I did switch to getElementById().
https://hg.mozilla.org/mozilla-central/rev/ac3ea3b31fe0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [computedview][ruleview][fixed-in-fx-team] → [computedview][ruleview]
Target Milestone: --- → Firefox 14
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.