Closed
Bug 702411
Opened 13 years ago
Closed 12 years ago
Rule view shouldn't update during highlighting
Categories
(DevTools :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
(Whiteboard: [computedview][ruleview])
Attachments
(1 file)
4.18 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
It needs to respect the highlighter's dim state.
Comment 1•12 years ago
|
||
This also goes for the computed view. The rule view updates and does not dim ... the style inspector does not update but does not dim. Ideally both tools should not update and should dim.
Whiteboard: [computedview][ruleview]
Updated•12 years ago
|
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dcamp
Comment 2•12 years ago
|
||
With bug 707809, the Rule View and the Computed View don't update anymore while inspecting. We just need a placeholder when there's nothing to show.
Assignee | ||
Comment 3•12 years ago
|
||
Adds a placeholder that matches the computed view's placeholder.
Attachment #615509 -
Flags: review?(paul)
Comment 4•12 years ago
|
||
Comment on attachment 615509 [details] [diff] [review] Empty placeholder + _showEmpty: function CssRuleView_showEmpty() + { + if (this.element.querySelectorAll("#noResults").length > 0) { or even just if ...getElementById("noResults") ... ? no real need for qSA.
Attachment #615509 -
Flags: review?(paul) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ac3ea3b31fe0
Whiteboard: [computedview][ruleview] → [computedview][ruleview][fixed-in-fx-team]
Assignee | ||
Comment 6•12 years ago
|
||
I did switch to getElementById().
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac3ea3b31fe0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [computedview][ruleview][fixed-in-fx-team] → [computedview][ruleview]
Target Milestone: --- → Firefox 14
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•