702465 - IntegrityError when saving Banner

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

Traceback (most recent call last):

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/contrib/admin/options.py", line 307, in wrapper
   return self.admin_site.admin_view(view)(*args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/utils/decorators.py", line 93, in _wrapped_view
   response = view_func(request, *args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/views/decorators/cache.py", line 79, in _wrapped_view_func
   response = view_func(request, *args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/contrib/admin/sites.py", line 197, in inner
   return view(request, *args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/utils/decorators.py", line 28, in _wrapper
   return bound_func(*args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/utils/decorators.py", line 93, in _wrapped_view
   response = view_func(request, *args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/utils/decorators.py", line 24, in bound_func
   return func(self, *args2, **kwargs2)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/transaction.py", line 217, in inner
   res = func(*args, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/contrib/admin/options.py", line 865, in add_view
   new_object = self.save_form(request, form, change=False)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/contrib/admin/options.py", line 659, in save_form
   return form.save(commit=False)

 File "/data/www/affiliates.allizom.org/affiliates-app/apps/badges/admin.py", line 37, in save
   model.badgelocale_set = badge_locales

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/fields/related.py", line 402, in __set__
   manager.add(*value)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/fields/related.py", line 430, in add
   obj.save()

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/base.py", line 460, in save
   self.save_base(using=using, force_insert=force_insert, force_update=force_update)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/base.py", line 553, in save_base
   result = manager._insert(values, return_id=update_pk, using=using)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/manager.py", line 195, in _insert
   return insert_query(self.model, values, **kwargs)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/query.py", line 1436, in insert_query
   return query.get_compiler(using=using).execute_sql(return_id)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/sql/compiler.py", line 791, in execute_sql
   cursor = super(SQLInsertCompiler, self).execute_sql(None)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/models/sql/compiler.py", line 735, in execute_sql
   cursor.execute(sql, params)

 File "/data/www/affiliates.allizom.org/affiliates-app/vendor/src/django/django/db/backends/mysql/base.py", line 86, in execute
   return self.cursor.execute(query, args)

 File "/usr/lib/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute
   self.errorhandler(self, exc, value)

 File "/usr/lib/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
   raise errorclass, errorvalue

IntegrityError: (1048, "Column 'badge_id' cannot be null")

Comment 1

[Osmose [:osmose, :mkelly]]

This is caused by saving a banner in the admin interface. Specifically, you must have added a BannerImage using the table at the bottom of the form, and do NOT specify a color for the image.

Comment 2

[Osmose [:osmose, :mkelly]]

This is more critical than originally thought; I can reproduce the issue when trying to create a new banner.

Comment 3

[Osmose [:osmose, :mkelly]]

Fixed in https://github.com/mozilla/affiliates/commit/d6ec1e02d42d96604837987f3bd5ff7936cdd0cc

Comment 4

[Matt Brandt [:mbrandt]]

Marking as QA verified. I haven't seen an error of this type in quite awhile.