702480 - Fix description of js-gc-heap-unused-fraction

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v1: trivial

This did not get updated correctly in bug 670596.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 574476 [details] [diff] [review]
v1: trivial

Review of attachment 574476 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCJSRuntime.cpp
@@ +2023,5 @@
>                                 data.gcHeapUnusedPercentage,
>                                 "Fraction of the garbage-collected JavaScript heap that is unused. "
>                                 "Computed as ('js-gc-heap-chunk-clean-unused' + "
> +                               "'js-gc-heap-chunk-dirty-unused' + 'js-gc-heap-decommitted' + "
> +                               "'js-gc-heap-arena-unused') / 'js-gc-heap'.",

I would have made 'js-gc-heap-decommitted' the 3rd operand in the sum to keep the two 'unused' reports together, but it's not a big deal.

Comment 2

[Igor Bukanov]

Could we also remove the useless inner loop "while (chunk)" loop in DecommitFreePages? The outer loop over all chunks is enough to get all the chunks.

Comment 3

[Terrence Cole [:terrence]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2057f46bf229
http://hg.mozilla.org/integration/mozilla-inbound/rev/2057f46bf229

and 

https://bugzilla.mozilla.org/show_bug.cgi?id=702681

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2057f46bf229