Last Comment Bug 702480 - Fix description of js-gc-heap-unused-fraction
: Fix description of js-gc-heap-unused-fraction
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Terrence Cole [:terrence]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-14 16:31 PST by Terrence Cole [:terrence]
Modified: 2012-02-01 13:57 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1: trivial (1.74 KB, patch)
2011-11-14 16:31 PST, Terrence Cole [:terrence]
n.nethercote: review+
Details | Diff | Review

Description Terrence Cole [:terrence] 2011-11-14 16:31:45 PST
Created attachment 574476 [details] [diff] [review]
v1: trivial

This did not get updated correctly in bug 670596.
Comment 1 Nicholas Nethercote [:njn] 2011-11-14 17:14:30 PST
Comment on attachment 574476 [details] [diff] [review]
v1: trivial

Review of attachment 574476 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCJSRuntime.cpp
@@ +2023,5 @@
>                                 data.gcHeapUnusedPercentage,
>                                 "Fraction of the garbage-collected JavaScript heap that is unused. "
>                                 "Computed as ('js-gc-heap-chunk-clean-unused' + "
> +                               "'js-gc-heap-chunk-dirty-unused' + 'js-gc-heap-decommitted' + "
> +                               "'js-gc-heap-arena-unused') / 'js-gc-heap'.",

I would have made 'js-gc-heap-decommitted' the 3rd operand in the sum to keep the two 'unused' reports together, but it's not a big deal.
Comment 2 Igor Bukanov 2011-11-14 22:51:52 PST
Could we also remove the useless inner loop "while (chunk)" loop in DecommitFreePages? The outer loop over all chunks is enough to get all the chunks.
Comment 4 Ed Morley [:emorley] 2011-11-16 03:15:39 PST
https://hg.mozilla.org/mozilla-central/rev/2057f46bf229

Note You need to log in before you can comment on or make changes to this bug.