Closed Bug 702480 Opened 8 years ago Closed 8 years ago

Fix description of js-gc-heap-unused-fraction

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: terrence, Assigned: terrence)

Details

Attachments

(1 file)

Attached patch v1: trivialSplinter Review
This did not get updated correctly in bug 670596.
Attachment #574476 - Flags: review?(nnethercote)
Comment on attachment 574476 [details] [diff] [review]
v1: trivial

Review of attachment 574476 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCJSRuntime.cpp
@@ +2023,5 @@
>                                 data.gcHeapUnusedPercentage,
>                                 "Fraction of the garbage-collected JavaScript heap that is unused. "
>                                 "Computed as ('js-gc-heap-chunk-clean-unused' + "
> +                               "'js-gc-heap-chunk-dirty-unused' + 'js-gc-heap-decommitted' + "
> +                               "'js-gc-heap-arena-unused') / 'js-gc-heap'.",

I would have made 'js-gc-heap-decommitted' the 3rd operand in the sum to keep the two 'unused' reports together, but it's not a big deal.
Attachment #574476 - Flags: review?(nnethercote) → review+
Could we also remove the useless inner loop "while (chunk)" loop in DecommitFreePages? The outer loop over all chunks is enough to get all the chunks.
https://hg.mozilla.org/mozilla-central/rev/2057f46bf229
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.