Closed Bug 702483 Opened 13 years ago Closed 13 years ago

Rename heap-committed-unallocated-fraction to heap-committed-fragmentation

Categories

(Toolkit :: about:memory, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11
Tracking Status
firefox11 --- fixed

People

(Reporter: Hughman, Assigned: Hughman)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

heap-committed-unallocated-fraction is confusing when reading on context of the memory reporters around it since its actually (heap-allocated / heap-committed).

It was decided in #memshrink with jlebar that heap-committed-fragmentation was a better name for it.
Attached patch Patch (obsolete) — Splinter Review
Changed reporter path and related variables around with same name.
Pushed to try, at Hugh's request.
Results will show up here: https://tbpl.mozilla.org/?tree=Try&rev=4dfae5242574
Attached patch PatchV2Splinter Review
V2 now with user and commit message! (hopefully)
Attachment #574516 - Attachment is obsolete: true
Comment on attachment 574535 [details] [diff] [review]
PatchV2

Try run looks like it has no fails except unrelated and things that were failing on m-c at push time.

So I think the next thing to do is get review, and who better than the person who I needed to ask about the problem in the first place?
Attachment #574535 - Flags: review?(justin.lebar+bug)
Comment on attachment 574535 [details] [diff] [review]
PatchV2

lgtm!
Attachment #574535 - Flags: review?(justin.lebar+bug) → review+
And I forgot to include the reviewer in the commit message.  Oh well.
https://hg.mozilla.org/mozilla-central/rev/f76ac3b9fcf2
Assignee: nobody → hughnougher
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: