The default bug view has changed. See this FAQ.

Rename heap-committed-unallocated-fraction to heap-committed-fragmentation

RESOLVED FIXED in Firefox 11

Status

()

Toolkit
about:memory
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Hughman, Assigned: Hughman)

Tracking

unspecified
mozilla11
x86
Windows 7
Points:
---

Firefox Tracking Flags

(firefox11 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

2.50 KB, patch
Justin Lebar (not reading bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
heap-committed-unallocated-fraction is confusing when reading on context of the memory reporters around it since its actually (heap-allocated / heap-committed).

It was decided in #memshrink with jlebar that heap-committed-fragmentation was a better name for it.
(Assignee)

Comment 1

5 years ago
Created attachment 574516 [details] [diff] [review]
Patch

Changed reporter path and related variables around with same name.
Pushed to try, at Hugh's request.
Results will show up here: https://tbpl.mozilla.org/?tree=Try&rev=4dfae5242574
(Assignee)

Comment 3

5 years ago
Created attachment 574535 [details] [diff] [review]
PatchV2

V2 now with user and commit message! (hopefully)
Attachment #574516 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Comment on attachment 574535 [details] [diff] [review]
PatchV2

Try run looks like it has no fails except unrelated and things that were failing on m-c at push time.

So I think the next thing to do is get review, and who better than the person who I needed to ask about the problem in the first place?
Attachment #574535 - Flags: review?(justin.lebar+bug)
Comment on attachment 574535 [details] [diff] [review]
PatchV2

lgtm!
Attachment #574535 - Flags: review?(justin.lebar+bug) → review+
Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/f76ac3b9fcf2
status-firefox11: --- → fixed
And I forgot to include the reviewer in the commit message.  Oh well.
https://hg.mozilla.org/mozilla-central/rev/f76ac3b9fcf2
Assignee: nobody → hughnougher
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.