Closed
Bug 702483
Opened 13 years ago
Closed 13 years ago
Rename heap-committed-unallocated-fraction to heap-committed-fragmentation
Categories
(Toolkit :: about:memory, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
Tracking | Status | |
---|---|---|
firefox11 | --- | fixed |
People
(Reporter: Hughman, Assigned: Hughman)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
2.50 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
heap-committed-unallocated-fraction is confusing when reading on context of the memory reporters around it since its actually (heap-allocated / heap-committed). It was decided in #memshrink with jlebar that heap-committed-fragmentation was a better name for it.
Assignee | ||
Comment 1•13 years ago
|
||
Changed reporter path and related variables around with same name.
Comment 2•13 years ago
|
||
Pushed to try, at Hugh's request. Results will show up here: https://tbpl.mozilla.org/?tree=Try&rev=4dfae5242574
Assignee | ||
Comment 3•13 years ago
|
||
V2 now with user and commit message! (hopefully)
Attachment #574516 -
Attachment is obsolete: true
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 574535 [details] [diff] [review] PatchV2 Try run looks like it has no fails except unrelated and things that were failing on m-c at push time. So I think the next thing to do is get review, and who better than the person who I needed to ask about the problem in the first place?
Attachment #574535 -
Flags: review?(justin.lebar+bug)
Comment 5•13 years ago
|
||
Comment on attachment 574535 [details] [diff] [review] PatchV2 lgtm!
Attachment #574535 -
Flags: review?(justin.lebar+bug) → review+
Comment 6•13 years ago
|
||
Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/f76ac3b9fcf2
status-firefox11:
--- → fixed
Comment 7•13 years ago
|
||
And I forgot to include the reviewer in the commit message. Oh well.
Comment 8•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f76ac3b9fcf2
Assignee: nobody → hughnougher
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•