702507 - can we remove JSCLASS_CONSTRUCT_PROTOTYPE and JS_IsConstructing_PossiblyWithGivenThisObject?

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

The semantics of both JSCLASS_CONSTRUCT_PROTOTYPE and JS_IsConstructing_PossiblyWithGivenThisObject are quite confusing.  
The last remaining uses were removed (presumably by waldo's sanity-bringing InitClass changes) which of course means they became immediately, and flagrantly, broken.  Since I think these were mostly for internal use, can we remove 'em?  I'll ask on the newsgroup as well.

Comment 1

[Luke Wagner [:luke]]

Also, thanks to bsdunx on irc for pointing this out.

Comment 2

[Brendan Eich [:brendan]]

They were only for E4X, as grep discloses:

$ grep CONSTRUCT_PROTO *cpp
jsobj.cpp:        if (clasp->flags & JSCLASS_CONSTRUCT_PROTOTYPE) {
jsobj.cpp:     * JSCLASS_CONSTRUCT_PROTOTYPE flags, and the instance does not have its
jsobj.cpp:                            JSCLASS_CONSTRUCT_PROTOTYPE)) &&
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |

Yank 'em, make sure ES4 tests pass.

/be

Comment 3

[Jeff Walden [:Waldo]]

I understand that the GNOME people use J_C_P, although they're doing away with those uses.  There was discussion of this on IRC recently; CCing the person who was doing that (I think?).

Comment 4

[Jasper St. Pierre]

Yes, see https://bugzilla.gnome.org/show_bug.cgi?id=663441

Comment 5

[Luke Wagner [:luke]]

Attachment: rm

No objections on the newsgroup.

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7b658e309b9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a7b658e309b9

Comment 8

[Jeff Walden [:Waldo]]

Luke, https://developer.mozilla.org/en/SpiderMonkey/JSAPI_Reference/JS_IsConstructing_PossiblyWithGivenThisObject could use axing.

Comment 9

[Luke Wagner [:luke]]

Marked obsolete.