Closed Bug 702507 Opened 8 years ago Closed 8 years ago

can we remove JSCLASS_CONSTRUCT_PROTOTYPE and JS_IsConstructing_PossiblyWithGivenThisObject?

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

The semantics of both JSCLASS_CONSTRUCT_PROTOTYPE and JS_IsConstructing_PossiblyWithGivenThisObject are quite confusing.  
The last remaining uses were removed (presumably by waldo's sanity-bringing InitClass changes) which of course means they became immediately, and flagrantly, broken.  Since I think these were mostly for internal use, can we remove 'em?  I'll ask on the newsgroup as well.
Also, thanks to bsdunx on irc for pointing this out.
They were only for E4X, as grep discloses:

$ grep CONSTRUCT_PROTO *cpp
jsobj.cpp:        if (clasp->flags & JSCLASS_CONSTRUCT_PROTOTYPE) {
jsobj.cpp:     * JSCLASS_CONSTRUCT_PROTOTYPE flags, and the instance does not have its
jsobj.cpp:                            JSCLASS_CONSTRUCT_PROTOTYPE)) &&
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |
jsxml.cpp:    JSCLASS_CONSTRUCT_PROTOTYPE |

Yank 'em, make sure ES4 tests pass.

/be
I understand that the GNOME people use J_C_P, although they're doing away with those uses.  There was discussion of this on IRC recently; CCing the person who was doing that (I think?).
Attached patch rmSplinter Review
No objections on the newsgroup.
Attachment #575208 - Flags: review?(jwalden+bmo)
Attachment #575208 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/a7b658e309b9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Marked obsolete.
You need to log in before you can comment on or make changes to this bug.