Last Comment Bug 702517 - [Azure] Increase canvas test tolerances so that we pass with Skia
: [Azure] Increase canvas test tolerances so that we pass with Skia
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Matt Woodrow (:mattwoodrow) (PTO until 27 June)
:
Mentors:
Depends on:
Blocks: 687187
  Show dependency treegraph
 
Reported: 2011-11-14 20:51 PST by Matt Woodrow (:mattwoodrow) (PTO until 27 June)
Modified: 2012-02-01 13:58 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Test changes (7.16 KB, patch)
2011-11-14 20:51 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
no flags Details | Diff | Review
Test changes (3.54 KB, patch)
2011-11-15 03:07 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
no flags Details | Diff | Review
About AzureBackend property and use it to mark tests passing with Skia (11.09 KB, patch)
2011-11-15 14:57 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
no flags Details | Diff | Review
Add gfxPlatform::SupportsAzure (9.82 KB, patch)
2011-11-17 15:45 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
jmuizelaar: review+
Details | Diff | Review
Add skia GfxInfo pref and use it to mark tests (7.33 KB, patch)
2011-11-17 15:46 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
jmuizelaar: review+
Details | Diff | Review
Add skia GfxInfo pref and use it to mark tests v2 (6.64 KB, patch)
2011-11-17 18:53 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
matt.woodrow: review+
Details | Diff | Review
Fix memory leak in GfxInfoCollector and add new DefineProperty overload (1.65 KB, patch)
2011-11-17 18:53 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
matt.woodrow: review+
Details | Diff | Review
Test changes v2 (3.71 KB, patch)
2011-11-17 19:25 PST, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
jmuizelaar: review+
Details | Diff | Review

Description Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-14 20:51:28 PST
Created attachment 574530 [details] [diff] [review]
Test changes

I'm not actually 100% sure that these aren't symptoms of worse bugs, but they are all single bit differences.
Comment 1 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-15 03:07:42 PST
Created attachment 574560 [details] [diff] [review]
Test changes

These tests fail in chrome on windows. Treating these are skia bugs.
Comment 2 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-15 14:57:27 PST
Created attachment 574701 [details] [diff] [review]
About AzureBackend property and use it to mark tests passing with Skia
Comment 3 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-17 15:45:55 PST
Created attachment 575314 [details] [diff] [review]
Add gfxPlatform::SupportsAzure
Comment 4 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-17 15:46:56 PST
Created attachment 575315 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests
Comment 5 Jeff Muizelaar [:jrmuizel] 2011-11-17 15:51:12 PST
Comment on attachment 575315 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests

Put the leak fix in a separate patch. Also, please add an implementation of DefineProperty that takes an ASCII string instead of converting in the caller.
Comment 6 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-17 18:53:17 PST
Created attachment 575361 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests v2

Removed leak fix and string conversion code.
Comment 7 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-17 18:53:56 PST
Created attachment 575362 [details] [diff] [review]
Fix memory leak in GfxInfoCollector and add new DefineProperty overload
Comment 8 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-17 19:25:31 PST
Created attachment 575367 [details] [diff] [review]
Test changes v2
Comment 9 Jeff Muizelaar [:jrmuizel] 2011-11-17 19:52:20 PST
Comment on attachment 575367 [details] [diff] [review]
Test changes v2

separate the gradients stuffs +

Note You need to log in before you can comment on or make changes to this bug.