Closed
Bug 702517
Opened 13 years ago
Closed 13 years ago
[Azure] Increase canvas test tolerances so that we pass with Skia
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(4 files, 4 obsolete files)
|
9.82 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
6.64 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
|
1.65 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
|
3.71 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
I'm not actually 100% sure that these aren't symptoms of worse bugs, but they are all single bit differences.
Attachment #574530 -
Flags: review?(jmuizelaar)
|
Assignee | |
Comment 1•13 years ago
|
||
These tests fail in chrome on windows. Treating these are skia bugs.
Attachment #574530 -
Attachment is obsolete: true
Attachment #574530 -
Flags: review?(jmuizelaar)
Attachment #574560 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #574701 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #574701 -
Attachment is obsolete: true
Attachment #574701 -
Flags: review?(jmuizelaar)
Attachment #575314 -
Flags: review?
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #575315 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #575314 -
Flags: review? → review?(jmuizelaar)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 575315 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests
Put the leak fix in a separate patch. Also, please add an implementation of DefineProperty that takes an ASCII string instead of converting in the caller.
Attachment #575315 -
Flags: review?(jmuizelaar) → review+
|
|
||
Updated•13 years ago
|
Attachment #575314 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Removed leak fix and string conversion code.
Attachment #575315 -
Attachment is obsolete: true
Attachment #575361 -
Flags: review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #575362 -
Flags: review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
Attachment #574560 -
Attachment is obsolete: true
Attachment #574560 -
Flags: review?(jmuizelaar)
Attachment #575367 -
Flags: review?(jmuizelaar)
|
|
||
Comment 9•13 years ago
|
||
Comment on attachment 575367 [details] [diff] [review]
Test changes v2
separate the gradients stuffs +
Attachment #575367 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 10•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fce30603aea9
https://hg.mozilla.org/integration/mozilla-inbound/rev/e789d1408f87
https://hg.mozilla.org/integration/mozilla-inbound/rev/c83fc47b1433
https://hg.mozilla.org/integration/mozilla-inbound/rev/7edace028a6b
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af4c72eafa7
Assignee: nobody → matt.woodrow
|
||
Comment 11•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fce30603aea9
https://hg.mozilla.org/mozilla-central/rev/e789d1408f87
https://hg.mozilla.org/mozilla-central/rev/e789d1408f87
https://hg.mozilla.org/mozilla-central/rev/7edace028a6b
https://hg.mozilla.org/mozilla-central/rev/4af4c72eafa7
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•