[Azure] Increase canvas test tolerances so that we pass with Skia

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

unspecified
mozilla11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 4 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 574530 [details] [diff] [review]
Test changes

I'm not actually 100% sure that these aren't symptoms of worse bugs, but they are all single bit differences.
Attachment #574530 - Flags: review?(jmuizelaar)
(Assignee)

Comment 1

6 years ago
Created attachment 574560 [details] [diff] [review]
Test changes

These tests fail in chrome on windows. Treating these are skia bugs.
Attachment #574530 - Attachment is obsolete: true
Attachment #574530 - Flags: review?(jmuizelaar)
Attachment #574560 - Flags: review?(jmuizelaar)
(Assignee)

Comment 2

6 years ago
Created attachment 574701 [details] [diff] [review]
About AzureBackend property and use it to mark tests passing with Skia
Attachment #574701 - Flags: review?(jmuizelaar)
(Assignee)

Comment 3

6 years ago
Created attachment 575314 [details] [diff] [review]
Add gfxPlatform::SupportsAzure
Attachment #574701 - Attachment is obsolete: true
Attachment #574701 - Flags: review?(jmuizelaar)
Attachment #575314 - Flags: review?
(Assignee)

Comment 4

6 years ago
Created attachment 575315 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests
Attachment #575315 - Flags: review?(jmuizelaar)
(Assignee)

Updated

6 years ago
Attachment #575314 - Flags: review? → review?(jmuizelaar)
Comment on attachment 575315 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests

Put the leak fix in a separate patch. Also, please add an implementation of DefineProperty that takes an ASCII string instead of converting in the caller.
Attachment #575315 - Flags: review?(jmuizelaar) → review+
Attachment #575314 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 575361 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests v2

Removed leak fix and string conversion code.
Attachment #575315 - Attachment is obsolete: true
Attachment #575361 - Flags: review+
(Assignee)

Comment 7

6 years ago
Created attachment 575362 [details] [diff] [review]
Fix memory leak in GfxInfoCollector and add new DefineProperty overload
Attachment #575362 - Flags: review+
(Assignee)

Comment 8

6 years ago
Created attachment 575367 [details] [diff] [review]
Test changes v2
Attachment #574560 - Attachment is obsolete: true
Attachment #574560 - Flags: review?(jmuizelaar)
Attachment #575367 - Flags: review?(jmuizelaar)
Comment on attachment 575367 [details] [diff] [review]
Test changes v2

separate the gradients stuffs +
Attachment #575367 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 10

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fce30603aea9
https://hg.mozilla.org/integration/mozilla-inbound/rev/e789d1408f87
https://hg.mozilla.org/integration/mozilla-inbound/rev/c83fc47b1433
https://hg.mozilla.org/integration/mozilla-inbound/rev/7edace028a6b
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af4c72eafa7
Assignee: nobody → matt.woodrow
https://hg.mozilla.org/mozilla-central/rev/fce30603aea9
https://hg.mozilla.org/mozilla-central/rev/e789d1408f87
https://hg.mozilla.org/mozilla-central/rev/e789d1408f87
https://hg.mozilla.org/mozilla-central/rev/7edace028a6b
https://hg.mozilla.org/mozilla-central/rev/4af4c72eafa7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.