Closed Bug 702517 Opened 8 years ago Closed 8 years ago

[Azure] Increase canvas test tolerances so that we pass with Skia

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(4 files, 4 obsolete files)

Attached patch Test changes (obsolete) — Splinter Review
I'm not actually 100% sure that these aren't symptoms of worse bugs, but they are all single bit differences.
Attachment #574530 - Flags: review?(jmuizelaar)
Attached patch Test changes (obsolete) — Splinter Review
These tests fail in chrome on windows. Treating these are skia bugs.
Attachment #574530 - Attachment is obsolete: true
Attachment #574530 - Flags: review?(jmuizelaar)
Attachment #574560 - Flags: review?(jmuizelaar)
Attachment #574701 - Attachment is obsolete: true
Attachment #574701 - Flags: review?(jmuizelaar)
Attachment #575314 - Flags: review?
Attachment #575315 - Flags: review?(jmuizelaar)
Attachment #575314 - Flags: review? → review?(jmuizelaar)
Comment on attachment 575315 [details] [diff] [review]
Add skia GfxInfo pref and use it to mark tests

Put the leak fix in a separate patch. Also, please add an implementation of DefineProperty that takes an ASCII string instead of converting in the caller.
Attachment #575315 - Flags: review?(jmuizelaar) → review+
Attachment #575314 - Flags: review?(jmuizelaar) → review+
Removed leak fix and string conversion code.
Attachment #575315 - Attachment is obsolete: true
Attachment #575361 - Flags: review+
Attached patch Test changes v2Splinter Review
Attachment #574560 - Attachment is obsolete: true
Attachment #574560 - Flags: review?(jmuizelaar)
Attachment #575367 - Flags: review?(jmuizelaar)
Comment on attachment 575367 [details] [diff] [review]
Test changes v2

separate the gradients stuffs +
Attachment #575367 - Flags: review?(jmuizelaar) → review+
You need to log in before you can comment on or make changes to this bug.