Last Comment Bug 702523 - js_FloorLog2wImpl should be public
: js_FloorLog2wImpl should be public
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Solaris
: -- normal (vote)
: mozilla11
Assigned To: Ginn Chen
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-14 21:43 PST by Ginn Chen
Modified: 2011-11-21 09:04 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (963 bytes, patch)
2011-11-14 21:46 PST, Ginn Chen
luke: review+
Details | Diff | Splinter Review

Description Ginn Chen 2011-11-14 21:43:41 PST
In Utility.h, we have
extern size_t js_FloorLog2wImpl(size_t n);
for some cases.

It will not work, if libmozjs.so is built instead of static_js.a.

We should use JS_PUBLIC_API instead.
Comment 1 Ginn Chen 2011-11-14 21:46:00 PST
Created attachment 574540 [details] [diff] [review]
patch
Comment 3 Matt Brubeck (:mbrubeck) 2011-11-21 09:04:17 PST
https://hg.mozilla.org/mozilla-central/rev/89932b056c11

Note You need to log in before you can comment on or make changes to this bug.