Closed
Bug 702596
Opened 13 years ago
Closed 12 years ago
rename balrog's "client" web portion to something different
Categories
(Release Engineering :: General, enhancement, P3)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
(Whiteboard: [updates])
Attachments
(1 file)
24.46 KB,
patch
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Currently, the part of Balrog that Firefox and other applications talk to is called "client" (eg, auslib/client, client.wsgi, client.ini-dist). We've also started to talk about a "Balrog client" being a client to the administrative API. This is starting to get confusing; we should find a new name for the application facing part.
Updated•13 years ago
|
Severity: normal → enhancement
Priority: -- → P5
Whiteboard: [updates]
Comment 1•13 years ago
|
||
found in triage; not sure of urgency on this, so marking as p5 for now. bhearsum, is that ok, or you need it sooner?
Assignee | ||
Comment 2•13 years ago
|
||
Going to try to get to this soon.
Assignee: nobody → bhearsum
Priority: P5 → P3
Assignee | ||
Comment 3•13 years ago
|
||
I'm having trouble coming up with any better names for this. My best idea is to skirt the issue and do the following
- Move the existing 'web' directory to 'admin'.
- Move the existing 'client' directory to 'web'.
- Rename client.wsgi/client.ini-dist to balrog.wsgi/balrog.ini-dist.
Anyone have strong feelings about that either way?
Assignee | ||
Comment 4•12 years ago
|
||
Passes unit tests and I ran both apps against a database dump locally. I also found a bug in auslib/admin/base.py where 'log' wasn't set, so I fixed that.
Attachment #630641 -
Flags: review?(nrthomas)
Comment 5•12 years ago
|
||
Comment on attachment 630641 [details] [diff] [review]
do the renaming from comment #3
Looks fine to me.
Attachment #630641 -
Flags: review?(nrthomas) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 630641 [details] [diff] [review]
do the renaming from comment #3
https://jenkins.mozilla.org/job/Balrog/93/
Attachment #630641 -
Flags: checked-in+
Assignee | ||
Comment 7•12 years ago
|
||
Landed cleanly, and relatively in sync with the IT changes from bug 763874.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•