702656 - Fennec zoomed shadow layers scrolling is incorrect

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Oleg Romashin (:romaxa)]

Open any page with iframes, zoom it  and try to scroll iframes

EXPECTED: iframe scrolled with the same speed as finger moves
ACTUAL: iframes scrolled with faster speed.

Also there are problems with fixed positioned layers which are translated much faster than it is needed while we zooming

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Fix shadow scale transforms calculation for remote viewport layer tree

Ok, here is not full reimplementation, but patch which makes current implementation works.
I killed all transforms, reimplemented it, checked all cases (iframes, multiple iframes, scrolling, zooming) with fennec and native embedding browser, created diff between previous implementation and new one and got this patch.
Haven't tested it with different iframes resolution

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 574614 [details] [diff] [review]
Fix shadow scale transforms calculation for remote viewport layer tree

Review of attachment 574614 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to rubber-stamp this. It's still unmaintainable. The methods and fields need to be very carefully documented, along with the invariants that hold between them.

Comment 3

[Oleg Romashin (:romaxa)]

Ok, at least we can enable fixed pos layers and enable some tests.
Will try to reorg nsContentView/nsIContentView ViewMap interfaces later

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b469ca7cef45