Fennec zoomed shadow layers scrolling is incorrect

RESOLVED FIXED in mozilla11

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Open any page with iframes, zoom it  and try to scroll iframes

EXPECTED: iframe scrolled with the same speed as finger moves
ACTUAL: iframes scrolled with faster speed.

Also there are problems with fixed positioned layers which are translated much faster than it is needed while we zooming
(Assignee)

Comment 1

6 years ago
Created attachment 574614 [details] [diff] [review]
Fix shadow scale transforms calculation for remote viewport layer tree

Ok, here is not full reimplementation, but patch which makes current implementation works.
I killed all transforms, reimplemented it, checked all cases (iframes, multiple iframes, scrolling, zooming) with fennec and native embedding browser, created diff between previous implementation and new one and got this patch.
Haven't tested it with different iframes resolution
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #574614 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Blocks: 656036
Comment on attachment 574614 [details] [diff] [review]
Fix shadow scale transforms calculation for remote viewport layer tree

Review of attachment 574614 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to rubber-stamp this. It's still unmaintainable. The methods and fields need to be very carefully documented, along with the invariants that hold between them.
Attachment #574614 - Flags: review?(roc) → review+
(Assignee)

Comment 3

6 years ago
Ok, at least we can enable fixed pos layers and enable some tests.
Will try to reorg nsContentView/nsIContentView ViewMap interfaces later
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b469ca7cef45
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.