70267 - Implement gopher searches

Status: VERIFIED FIXED

(Core :: Networking, enhancement)

Description

[Bradley Baetz]

I need to implement gopher searches, remembering darin's comments in bug 61167.

Comment 1

[Bradley Baetz]

I've done this, but I need to tidy up the dir viewer code so that the listings
in the dirviewer are correct. Marking dependancy.

Comment 2

[Bradley Baetz]

This now works. As a bonus, I no longer add the url to the load group twice.
Oops.

I've also added another couple of PR_LOG calls.

You may need the patches to bug 70529 if you try loading the query url directly
- go to the above url, and select the "McGill names and phone numbers" link.

ccing darin and dougt for r/sr

Comment 3

[Bradley Baetz]

Attachment: patch

Comment 4

[Darin Fisher]

just one nit: the ASSERTION in SetNotificationCallbacks is probably wrong...
the NS_WARNING before attempting to prompt is much better IMO.  the client
could for whatever reason call SetNotificationCallbacks more than once with
a different value for aNotificationCallbacks each time.  my point is that it
isn't the value of mPrompter when SetNotificationCallbacks is called that
matters... it's the value of mPrompter before you go to use it that matters.

fix this and r/sr=darin

Comment 5

[Doug Turner (:dougt)]

r=dougt.

Comment 6

[Bradley Baetz]

Checked in.

Comment 7

[benc]

VERIFIED:
mozilla 0.9 all plats.