702691 - Icon support is broken in Windows XP

Status: VERIFIED FIXED

(Web Apps :: Extension, defect, P2)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Extra flags need to be sent to the encoder to support Windows XP style icons.

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Investigated this further and discussed with bbondy.  We're going to have to modify the `encodeImage` and `encodeScaledImage` functions of `imgITools` (https://mxr.mozilla.org/mozilla-central/source/image/public/imgITools.idl) to allow an extra "output options" string.

This string will be passed along to the icon encoder in its `InitFromData` function: https://mxr.mozilla.org/mozilla-central/source/image/src/imgTools.cpp?rev=aacc24a42885#218 (the last argument is currently `EmptyString()` but we would like to pass in format arguments)

imgIEncoder is already set up to receive the output options: https://mxr.mozilla.org/mozilla-central/source/image/public/imgIEncoder.idl

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

The fix for 704558 should be going in to Nightlies soon.  Assuming it works, we will have icon support for Apps in FF11.

Firefox 11 is scheduled for release on 2011-03-13 (https://wiki.mozilla.org/RapidRelease/Calendar) which is 2 weeks after we're planning to release Apps.  This means that, when we release Apps, users on Windows XP will see no icon support for them.

If we push the fix for 704558 into 10, it will be released on 2012-01-31.  In that scenario, only users who are still running FF9 will see no icon support in WinXP (FF9 is the minimum supported version for Apps).

I'm not sure how hard it is to get a fix pushed to Aurora, but the fix for 704558 is small so that may help our case.

Thoughts for/against trying to get the fix for 704558 pushed to Aurora?

Comment 3

[Jason Smith [:jsmith]]

Currently resolved as a result of bug 704558. Going to go verify now.

Comment 4

[Jason Smith [:jsmith]]

Verification of this bug is blocked by Bug 725780.

Comment 5

[Jason Smith [:jsmith]]

Saw this fixed yesterday, but now it appears to be broken again with the extension build for 3/1.

Steps used:

1. Install the latest build of the extension
2. Go to apps.mozillalabs.com/appdir
3. Install BarFight natively

Expected:

Icon should show up on native desktop.

Actual:

A broken image icon is shown instead.

Comment 6

[Jason Smith [:jsmith]]

Attachment: BarFight No Icon

Comment 7

[Jason Smith [:jsmith]]

Looks like the steps found above may be a different issue and logged. Resolving this for now.