702907 - Zooming should be disabled while a video is in fullscreen mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Cristian Nicolae (:xti)]

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111115
Firefox/11.0a1 Fennec/11.0a1
Devices: Motorola Droid 2
OS: Android 2.3.3

Steps to reproduce:
1. Open Fennec App
2. Browse to http://random.pavlov.net/video.html
3. Long tap on video for the Context Menu
4. Tap on Full Screen option
5. Perform a zoom-in/out action

Expected result:
Zooming is disabled while a video is in fullscreen mode.

Actual result:
Zooming still works even if the video is playing in fullscreen mode.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

QA verifiers : Please test bug Bug 706694 if this gets resolved.  that bug involves panning not zooming.

Comment 2

[Cristian Nicolae (:xti)]

(In reply to Naoki Hirata :nhirata from comment #1)
> QA verifiers : Please test bug Bug 706694 if this gets resolved.  that bug
> involves panning not zooming.

I've commented in bug 706694. It doesn't involve panning either. It seems that all content is automatically zoomed out if Full Screen option is tapped.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 604071 [details] [diff] [review]
patch

I'm slightly worried this is too heavy-handed (are there other use cases of requestFullScreen where zooming *should* remain enabled?) but it seems like a reasonable step.  If it causes problems for other use cases we can fix them.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbace64ae2eb

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/fbace64ae2eb

Comment 7

[Cristian Nicolae (:xti)]

Zoom is disabled in Full Screen mode. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-21)
Device: Galaxy Nexus
OS: Android 4.0.2