Closed
Bug 703041
Opened 13 years ago
Closed 12 years ago
WebConsoleHelp has an error at the top
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: dangoor, Assigned: msucan)
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file)
838 bytes,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
When I open the Web Console and type "help", I am taken to this page: https://developer.mozilla.org/AppLinks/WebConsoleHelp?locale=en-US At the top of the page, there's an error message with a red background that says: This page isn't available in your language; can you help? and links to: https://developer.mozilla.org/-US/Using_the_Web_Console/Helpers that link doesn't work, and the WebConsoleHelp page is fine in English.
Updated•13 years ago
|
Component: Website → Docs Platform
QA Contact: website → docs-platform
Comment 1•12 years ago
|
||
Even worse now, typing "help" in the Web Console leads to a 404 page, because the page lives here now: https://developer.mozilla.org/docs/Tools/Web_Console/Helpers
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Florian Scholz [:fs] from comment #1) > Even worse now, typing "help" in the Web Console leads to a 404 page, > because the page lives here now: > https://developer.mozilla.org/docs/Tools/Web_Console/Helpers This is working for me, and ending up on this URL: https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Helpers?redirectlocale=en-US&redirectslug=Tools%2FWeb_Console%2FWebConsoleHelp Perhaps there's a problem with the locale it's detecting for you?
Comment 3•12 years ago
|
||
(In reply to Kevin Dangoor from comment #2) > Perhaps there's a problem with the locale it's detecting for you? Probably, yes. I'm on "de" (German) and when typing "help" I end up here: https://developer.mozilla.org/de/AppLinks/WebConsoleHelp?locale=de-DE which is a 404.
Comment 4•12 years ago
|
||
whoa. "help" goes to https://developer.mozilla.org/AppLinks/WebConsoleHelp?locale=en which goes thru 7 redirects to get to https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Helpers?redirectlocale=en-US&redirectslug=Tools%2FWeb_Console%2FWebConsoleHelp It should really go to: https://developer.mozilla.org/docs/Tools/Web_Console/Helpers Which will incur a single redirect to the right locale-specific page (if it exists). Kevin, should we move this bug to dev tools to update the "help" command url?
Comment 5•12 years ago
|
||
Kevin - even better, "help" should send a HEAD request to that url with the user's Accept-Language value, follow redirects, and then cache whatever url is the final landing page for the request. That way if the page moves again "help" will still avoid the redirects.
Reporter | ||
Comment 6•12 years ago
|
||
Adding Mihai and Rob so that they can help decide the best implementation route.
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Luke Crouch [:groovecoder] from comment #5) > Kevin - even better, "help" should send a HEAD request to that url with the > user's Accept-Language value, follow redirects, and then cache whatever url > is the final landing page for the request. That way if the page moves again > "help" will still avoid the redirects. Shouldn't simply opening a tab that points to https://developer.mozilla.org/AppLinks/WebConsoleHelp?locale=en .... redirect the user to the correct page? Or shall we point the user to a different url?
Comment 8•12 years ago
|
||
It does, after *SEVEN* redirects. We should send the user to https://developer.mozilla.org/docs/Tools/Web_Console/Helpers and they will only get 1 redirect to their locale-specific page.
Comment 9•12 years ago
|
||
Worth emphasizing - this may not be so bad for en-US visitors, but in Brazil it's an extra 3.5s of waiting for the help page: http://www.webpagetest.org/result/120910_FD_HT1/1/details/
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Luke Crouch [:groovecoder] from comment #8) > It does, after *SEVEN* redirects. We should send the user to > https://developer.mozilla.org/docs/Tools/Web_Console/Helpers and they will > only get 1 redirect to their locale-specific page. Then is it sufficient for us to only change the help() function to open https://developer.mozilla.org/docs/Tools/Web_Console/Helpers ? I can quickly make a patch for this, if yes.
Comment 11•12 years ago
|
||
Yeah, that'd be good.
Assignee | ||
Comment 12•12 years ago
|
||
Updated•12 years ago
|
Attachment #660024 -
Flags: review?(past) → review+
Assignee | ||
Comment 13•12 years ago
|
||
Comment on attachment 660024 [details] [diff] [review] [in-fx-team] proposed fix Landed: https://hg.mozilla.org/integration/fx-team/rev/eb0483d38a78
Attachment #660024 -
Attachment description: proposed fix → [in-fx-team] proposed fix
Assignee | ||
Updated•12 years ago
|
Component: Docs Platform → Developer Tools: Console
OS: Mac OS X → All
Product: Mozilla Developer Network → Firefox
Hardware: x86 → All
Whiteboard: [fixed-in-fx-team]
Version: unspecified → Trunk
Comment 14•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eb0483d38a78
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → Firefox 18
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•