703041 - WebConsoleHelp has an error at the top

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Kevin Dangoor]

When I open the Web Console and type "help", I am taken to this page:

https://developer.mozilla.org/AppLinks/WebConsoleHelp?locale=en-US

At the top of the page, there's an error message with a red background that says:

This page isn't available in your language; can you help?

and links to: https://developer.mozilla.org/-US/Using_the_Web_Console/Helpers

that link doesn't work, and the WebConsoleHelp page is fine in English.

Comment 1

[Florian Scholz (Open Web Docs)]

Even worse now, typing "help" in the Web Console leads to a 404 page, because the page lives here now: https://developer.mozilla.org/docs/Tools/Web_Console/Helpers

Comment 2

[Kevin Dangoor]

(In reply to Florian Scholz [:fs] from comment #1)
> Even worse now, typing "help" in the Web Console leads to a 404 page,
> because the page lives here now:
> https://developer.mozilla.org/docs/Tools/Web_Console/Helpers

This is working for me, and ending up on this URL:

https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Helpers?redirectlocale=en-US&redirectslug=Tools%2FWeb_Console%2FWebConsoleHelp

Perhaps there's a problem with the locale it's detecting for you?

Comment 3

[Florian Scholz (Open Web Docs)]

(In reply to Kevin Dangoor from comment #2)
> Perhaps there's a problem with the locale it's detecting for you?

Probably, yes. I'm on "de" (German) and when typing "help" I end up here:
https://developer.mozilla.org/de/AppLinks/WebConsoleHelp?locale=de-DE which is a 404.

Comment 4

[Luke Crouch [:groovecoder]]

whoa. "help" goes to https://developer.mozilla.org/AppLinks/WebConsoleHelp?locale=en which goes thru 7 redirects to get to https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Helpers?redirectlocale=en-US&redirectslug=Tools%2FWeb_Console%2FWebConsoleHelp

It should really go to:

https://developer.mozilla.org/docs/Tools/Web_Console/Helpers

Which will incur a single redirect to the right locale-specific page (if it exists). Kevin, should we move this bug to dev tools to update the "help" command url?

Comment 5

[Luke Crouch [:groovecoder]]

Kevin - even better, "help" should send a HEAD request to that url with the user's Accept-Language value, follow redirects, and then cache whatever url is the final landing page for the request. That way if the page moves again "help" will still avoid the redirects.

Comment 6

[Kevin Dangoor]

Adding Mihai and Rob so that they can help decide the best implementation route.

Comment 7

[Mihai Sucan [:msucan]]

(In reply to Luke Crouch [:groovecoder] from comment #5)
> Kevin - even better, "help" should send a HEAD request to that url with the
> user's Accept-Language value, follow redirects, and then cache whatever url
> is the final landing page for the request. That way if the page moves again
> "help" will still avoid the redirects.

Shouldn't simply opening a tab that points to https://developer.mozilla.org/AppLinks/WebConsoleHelp?locale=en .... redirect the user to the correct page? Or shall we point the user to a different url?

Comment 8

[Luke Crouch [:groovecoder]]

It does, after *SEVEN* redirects. We should send the user to https://developer.mozilla.org/docs/Tools/Web_Console/Helpers and they will only get 1 redirect to their locale-specific page.

Comment 9

[Luke Crouch [:groovecoder]]

Worth emphasizing - this may not be so bad for en-US visitors, but in Brazil it's an extra 3.5s of waiting for the help page:

http://www.webpagetest.org/result/120910_FD_HT1/1/details/

Comment 10

[Mihai Sucan [:msucan]]

(In reply to Luke Crouch [:groovecoder] from comment #8)
> It does, after *SEVEN* redirects. We should send the user to
> https://developer.mozilla.org/docs/Tools/Web_Console/Helpers and they will
> only get 1 redirect to their locale-specific page.

Then is it sufficient for us to only change the help() function to open https://developer.mozilla.org/docs/Tools/Web_Console/Helpers ? I can quickly make a patch for this, if yes.

Comment 11

[Luke Crouch [:groovecoder]]

Yeah, that'd be good.

Comment 12

[Mihai Sucan [:msucan]]

Attachment: [in-fx-team] proposed fix

Comment 13

[Mihai Sucan [:msucan]]

Comment on attachment 660024 [details] [diff] [review]
[in-fx-team] proposed fix

Landed:
https://hg.mozilla.org/integration/fx-team/rev/eb0483d38a78

Comment 14

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/eb0483d38a78