Open Bug 703042 Opened 11 years ago Updated 9 years ago

Desktop Linux/Gtk build with --disable-pango is broken

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

People

(Reporter: jfkthame, Unassigned)

References

()

Details

Attachments

(3 files, 2 obsolete files)

This was broken due to gfxFT2Font* changes and refactoring in bug 684889. Although the --disable-pango configuration is not something we actually ship, or care much about, it may sometimes be useful for debugging purposes as it produces a desktop Firefox build whose font-rendering codepaths are much more similar to the Mobile product.

The attached patch allows the browser to build and run, although it's rather rough-and-ready. A better fix would involve substantial reworking of gfxPlatformGtk to properly use gfxFT2FontList, but it's not a high priority IMO.
Attachment #574971 - Attachment is patch: true
you have disabled whole FT2 stuff, why? does it display any fonts in that mode?
IIRC qt build was compiling fine without these changes...
I can confirm this. The build fails here -- http://sprunge.us/EIhW 

The mozconfig used is here -- http://sprunge.us/BjYA
With this patch, the browser seems to build and run OK, except that user fonts (@font-face rules) are not supported.
Attachment #574971 - Attachment is obsolete: true
Comment on attachment 626042 [details] [diff] [review]
patch, fix the Linux/GTK build with --disable-pango so that it compiles again

Works fine for me
Attachment #626042 - Flags: feedback+
Duplicate of this bug: 754506
Attachment #627970 - Attachment is obsolete: true
Attachment #633955 - Flags: feedback?(jfkthame)
Duplicate of this bug: 708818
Is this likely to land soon? It's blocking my refactoring in bug 762737 as we use the non-Pango gfxFont implementation for Skia/Linux.
The first patch has bit-rotted quite badly, unfortunately.  (I wanted it because I'm writing a memory reporter for Freetype because it uses a substantial amount of memory on B2G, and I wanted to test the reporter code on desktop first.)
Attachment #626095 - Flags: review?(jfkthame)
Attachment #633955 - Flags: feedback?(jfkthame)
Clearing old review requests. Bug 947379 is removing the MOZ_PANGO conditional altogether. If there's anything here we still want to do, let's start afresh; otherwise, I think this is WontFix.
You need to log in before you can comment on or make changes to this bug.