Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 703098 - Remove the url.file.exist check in BrowserCLH.js
: Remove the url.file.exist check in BrowserCLH.js
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: x86 Linux
: P3 normal (vote)
: ---
Assigned To: Doug Turner (:dougt)
: Sebastian Kaspari (:sebastian)
Depends on:
  Show dependency treegraph
Reported: 2011-11-16 14:24 PST by Mark Finkle (:mfinkle) (use needinfo?)
Modified: 2012-01-09 11:17 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v.1 (885 bytes, patch)
2011-11-17 11:49 PST, Doug Turner (:dougt)
mark.finkle: review+
Details | Diff | Splinter Review

Description Mark Finkle (:mfinkle) (use needinfo?) 2011-11-16 14:24:52 PST
Bug 701483 added better file URL resolution, but we should try to optimize the code a bit. Removing unneeded file.exist checks should speed up the code.
Comment 1 Doug Turner (:dougt) 2011-11-17 11:49:20 PST
Created attachment 575252 [details] [diff] [review]
patch v.1

stats are bad.
Comment 2 Doug Turner (:dougt) 2011-11-17 11:49:40 PST
Comment 3 Mark Finkle (:mfinkle) (use needinfo?) 2011-11-17 12:55:28 PST
Comment on attachment 575252 [details] [diff] [review]
patch v.1

> function resolveURIInternal(aCmdLine, aArgument) {
>   let uri = aCmdLine.resolveURI(aArgument);

Remove this blank line

>+  if (uri)
>       return uri;

2 space indent

r+ with nits fixed
Comment 4 Doug Turner (:dougt) 2011-11-17 13:11:53 PST

Note You need to log in before you can comment on or make changes to this bug.