703123 - web console "Web Developer" filter button should be renamed

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Heather Arthur [:harth]]

The filter button for filtering console.log() etc messages should be renamed from "Web Developer".

I was talking to a web dev, and he said "I don't use that 'Web Developer' button, whatever that is". I remember an initial confusion with the naming too, and continuing confusion even though I know what it is now.

I suggest "Logging".

Comment 1

[Dave Camp (:dcamp)]

Yeah, that makes more sense to me.

Comment 2

[Heather Arthur [:harth]]

Commented in https://bugzilla.mozilla.org/show_bug.cgi?id=703615#c2 too, but I forgot to mention here that potch also suggested merging the 'Web Developer' options under 'JS'.

Comment 3

[Rob Campbell [:rc] (:robcee)]

(In reply to Heather Arthur [:harth] from comment #2)
> Commented in https://bugzilla.mozilla.org/show_bug.cgi?id=703615#c2 too, but
> I forgot to mention here that potch also suggested merging the 'Web
> Developer' options under 'JS'.

Respectfully disagree because of what I said in https://bugzilla.mozilla.org/show_bug.cgi?id=703615#c3.

Comment 4

[Sonny Piers [:sonny]]

Attachment: patch v1

Comment 5

[Mihai Sucan [:msucan]]

Comment on attachment 575657 [details] [diff] [review]
patch v1

Review of attachment 575657 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thank you Sonny!

Please also update the localization note.

Comment 6

[Sonny Piers [:sonny]]

Attachment: patch v1.1

Comment 7

[Mihai Sucan [:msucan]]

Axel: should we rename the property name as well?

Comment 8

[Francesco Lodolo [:flod]]

(obviously not Axel) Yes, please rename the property to make all localizers aware of this change. 

Not sure if the "page" explanation in the localization note is still needed, since "Logging" is easier to understand. Maybe this is enough?

# This is used as the label for the "Logging" button on the toolbar. It
# shows or hides messages that the web developer inserted on the page for
# debugging purposes, using calls such console.log() and console.error().

Comment 9

[Sonny Piers [:sonny]]

I think we should conserve the page explanation because others menus are about logging stuffs too.
Tell me what you think.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 575661 [details] [diff] [review]
patch v1.1

Yes, you need to change the property name.

Comment 11

[Sonny Piers [:sonny]]

Attachment: patch v2

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 575744 [details] [diff] [review]
patch v2

> # This is used as the text of the tool tip for the "Web Developer" button on
> # the toolbar.

Still need to replace "Web Developer" with "Logging" here. Looks good otherwise. Thanks!

Comment 13

[Sonny Piers [:sonny]]

Attachment: patch v2.1

Comment 14

[Sonny Piers [:sonny]]

Fixed!

Comment 15

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/971edb844b3d

Comment 16

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/971edb844b3d