703125 - Memory increase/leak when scrolling page rapidly

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Testing on several pages, CNN, MSNBC, NeoWin.net shows the problem but I'm sure others may as well.

1. Visit htt://www.Neowin.net 
2. Using scroll-wheel on mouse rapidly scroll page up and down and notice that the memory increases as you continue scrolling up/down.
3. Memory is not released when you stop scrolling.

This results in increased memory use over a period of time as the browser is used over a long period of time.  

Seems to have regressed with merge:
20111114081649 eb84780783ed good
20111114190451 f694183357ec bad (merge) 

Maybe someone could bisect the patches that landed in the merge.

Tested on Win7 x64 m-c hourly builds.

Comment 1

[Alice0775 White]

Regression window(m-i)
Works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b1e2ee0bbdb5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111113 Firefox/11.0a1 ID:20111113200306
Fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6ae6d3beeaf4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111113 Firefox/11.0a1 ID:20111113203057
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b1e2ee0bbdb5&tochange=6ae6d3beeaf4

Comment 2

[Alice0775 White]

In local build,
built from 6ae6d3beeaf4 : can reproduce
built from e6705f49eaaa : works fine
built from 677fe017e6a0 : works fine
built from b1e2ee0bbdb5 : works fine

Triggered by:
6ae6d3beeaf4	Joe Drew — Bug 685767 - Factor blurring out into its own class, and use it from gfxAlphaBoxBlur. r=mattwoodrow

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I backed out Bug 685767

https://hg.mozilla.org/mozilla-central/rev/b62e6ee5ba9b

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)
> I backed out Bug 685767
> 
> https://hg.mozilla.org/mozilla-central/rev/b62e6ee5ba9b

Testing with the latest hourly m-c win32 build I can no longer repo, so the backout fixed the leak.  Leave this open ?  or ?

Comment 5

[Joe Drew (not getting mail)]

The backout solved this; I'll work on fixing the leak in the original bug.

Comment 6

[Joe Drew (not getting mail)]

Alice, did this happen in a debug build? Did waiting a little make it (maybe only mostly) go away? I'm having issues reproducing this. :(

Comment 7

[Joe Drew (not getting mail)]

OK, I can reproduce it in a nightly, so I'll try a non-debug build with symbols.