Last Comment Bug 703174 - browser_drag_bookmarks_on_toolbar.js calls finish() more than once
: browser_drag_bookmarks_on_toolbar.js calls finish() more than once
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Cameron McCormack (:heycam) (away Jun 25 – Jul 10)
:
Mentors:
Depends on:
Blocks: 703176
  Show dependency treegraph
 
Reported: 2011-11-16 19:06 PST by Cameron McCormack (:heycam) (away Jun 25 – Jul 10)
Modified: 2012-02-01 14:00 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make browser_drag_bookmarks_on_toolbar.js only call finish() once. (1.35 KB, patch)
2011-11-16 19:09 PST, Cameron McCormack (:heycam) (away Jun 25 – Jul 10)
mak77: review+
Details | Diff | Review

Description Cameron McCormack (:heycam) (away Jun 25 – Jul 10) 2011-11-16 19:06:59 PST
This can cause test framework problems.
Comment 1 Cameron McCormack (:heycam) (away Jun 25 – Jul 10) 2011-11-16 19:09:20 PST
Created attachment 575076 [details] [diff] [review]
Make browser_drag_bookmarks_on_toolbar.js only call finish() once.
Comment 2 Marco Bonardo [::mak] 2011-11-17 03:34:07 PST
Comment on attachment 575076 [details] [diff] [review]
Make browser_drag_bookmarks_on_toolbar.js only call finish() once.

Review of attachment 575076 [details] [diff] [review]:
-----------------------------------------------------------------

oops, good catch!
Comment 3 Cameron McCormack (:heycam) (away Jun 25 – Jul 10) 2011-11-17 13:10:39 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/c99d183ec8ab
Comment 4 Ed Morley [:emorley] 2011-11-18 03:24:22 PST
https://hg.mozilla.org/mozilla-central/rev/c99d183ec8ab

Note You need to log in before you can comment on or make changes to this bug.