Last Comment Bug 703178 - Build warnings in security/manager/ssl/src/ [-Wunused-but-set-variable]
: Build warnings in security/manager/ssl/src/ [-Wunused-but-set-variable]
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: Security (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla13
Assigned To: Atul Aggarwal
:
Mentors:
: 692681 (view as bug list)
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2011-11-16 19:52 PST by Atul Aggarwal
Modified: 2013-03-02 01:09 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (140 bytes, patch)
2011-11-16 20:14 PST, Atul Aggarwal
no flags Details | Diff | Review
Patch v1.01 (14.88 KB, patch)
2011-11-16 21:01 PST, Atul Aggarwal
kaie: review+
Details | Diff | Review
Patch v1.10 (12.57 KB, patch)
2012-02-21 09:41 PST, Atul Aggarwal
no flags Details | Diff | Review

Description Atul Aggarwal 2011-11-16 19:52:44 PST
1 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSComponent.cpp:1361:12    : warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]       
  2 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSComponent.cpp:2278:16    : warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
  3 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSIOLayer.cpp:3288:13:     warning: variable ‘srv’ set but not used [-Wunused-but-set-variable]
  4 /mozilla/mozilla-central/security/manager/ssl/src/nsCMSSecureMessage.cpp:176    :11: warning: variable ‘item’ set but not used [-Wunused-but-set-variable]
  5 /mozilla/mozilla-central/security/manager/ssl/src/nsKeygenHandler.cpp:512:13    : warning: variable ‘type’ set but not used [-Wunused-but-set-variable]
  6 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:145    :17: warning: variable ‘moduleID’ set but not used [-Wunused-but-set-variabl    e]
  7 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:145    :26: warning: variable ‘slotID’ set but not used [-Wunused-but-set-variable]
  8 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:125    7:12: warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
Comment 1 Atul Aggarwal 2011-11-16 20:14:12 PST
Created attachment 575080 [details] [diff] [review]
Patch v1
Comment 2 Atul Aggarwal 2011-11-16 21:01:19 PST
Created attachment 575086 [details] [diff] [review]
Patch v1.01

Also fixing couple of deprecated warnings like
/mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertTrust.cpp:125:36: warning: ‘__CERTDB_VALID_PEER’ is deprecated (de    clared at ../../../../dist/include/certdb.h:61): CERTDB_VALID_PEER is now CERTDB_TERMINAL_RECORD [-Wdeprecated-declarations]
Comment 3 Atul Aggarwal 2012-02-21 06:16:58 PST
Pinging for code review.
Comment 4 Kai Engert (:kaie) 2012-02-21 07:02:28 PST
Comment on attachment 575086 [details] [diff] [review]
Patch v1.01

r=kaie

If you cannot check this in yourself, please add keyword checkin-needed

Thanks for the patch
Comment 5 Kai Engert (:kaie) 2012-02-21 08:05:31 PST
I'm afraid your patch no longer applies, it needs to be updated to latest mozilla-central.
Comment 6 Atul Aggarwal 2012-02-21 09:41:28 PST
Created attachment 599227 [details] [diff] [review]
Patch v1.10

Rebasing the patch over current m-c.
Comment 8 Ed Morley [:emorley] 2012-02-22 10:38:45 PST
https://hg.mozilla.org/mozilla-central/rev/daceb968bf88
Comment 9 :Cykesiopka 2013-03-02 01:09:33 PST
*** Bug 692681 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.