Closed
Bug 703178
Opened 14 years ago
Closed 14 years ago
Build warnings in security/manager/ssl/src/ [-Wunused-but-set-variable]
Categories
(Core :: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: atulagrwl, Assigned: atulagrwl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 2 obsolete files)
|
12.57 KB,
patch
|
Details | Diff | Splinter Review |
1 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSComponent.cpp:1361:12 : warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
2 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSComponent.cpp:2278:16 : warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
3 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSIOLayer.cpp:3288:13: warning: variable ‘srv’ set but not used [-Wunused-but-set-variable]
4 /mozilla/mozilla-central/security/manager/ssl/src/nsCMSSecureMessage.cpp:176 :11: warning: variable ‘item’ set but not used [-Wunused-but-set-variable]
5 /mozilla/mozilla-central/security/manager/ssl/src/nsKeygenHandler.cpp:512:13 : warning: variable ‘type’ set but not used [-Wunused-but-set-variable]
6 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:145 :17: warning: variable ‘moduleID’ set but not used [-Wunused-but-set-variabl e]
7 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:145 :26: warning: variable ‘slotID’ set but not used [-Wunused-but-set-variable]
8 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:125 7:12: warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → atulagrwl
Attachment #575080 -
Flags: review?(kaie)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [build_warning]
|
|
Assignee | |
Comment 2•14 years ago
|
||
Also fixing couple of deprecated warnings like
/mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertTrust.cpp:125:36: warning: ‘__CERTDB_VALID_PEER’ is deprecated (de clared at ../../../../dist/include/certdb.h:61): CERTDB_VALID_PEER is now CERTDB_TERMINAL_RECORD [-Wdeprecated-declarations]
Attachment #575080 -
Attachment is obsolete: true
Attachment #575080 -
Flags: review?(kaie)
Attachment #575086 -
Flags: review?(kaie)
|
||
Updated•14 years ago
|
Blocks: buildwarning
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pinging for code review.
|
||
Comment 4•14 years ago
|
||
Comment on attachment 575086 [details] [diff] [review]
Patch v1.01
r=kaie
If you cannot check this in yourself, please add keyword checkin-needed
Thanks for the patch
Attachment #575086 -
Flags: review?(kaie) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•14 years ago
|
||
I'm afraid your patch no longer applies, it needs to be updated to latest mozilla-central.
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•14 years ago
|
||
Rebasing the patch over current m-c.
Attachment #575086 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 7•14 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla13
|
|
||
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•