Build warnings in security/manager/ssl/src/ [-Wunused-but-set-variable]

RESOLVED FIXED in mozilla13

Status

()

Core
Security
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Atul Aggarwal, Assigned: Atul Aggarwal)

Tracking

(Blocks: 1 bug)

unspecified
mozilla13
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
1 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSComponent.cpp:1361:12    : warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]       
  2 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSComponent.cpp:2278:16    : warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
  3 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSIOLayer.cpp:3288:13:     warning: variable ‘srv’ set but not used [-Wunused-but-set-variable]
  4 /mozilla/mozilla-central/security/manager/ssl/src/nsCMSSecureMessage.cpp:176    :11: warning: variable ‘item’ set but not used [-Wunused-but-set-variable]
  5 /mozilla/mozilla-central/security/manager/ssl/src/nsKeygenHandler.cpp:512:13    : warning: variable ‘type’ set but not used [-Wunused-but-set-variable]
  6 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:145    :17: warning: variable ‘moduleID’ set but not used [-Wunused-but-set-variabl    e]
  7 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:145    :26: warning: variable ‘slotID’ set but not used [-Wunused-but-set-variable]
  8 /mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertificateDB.cpp:125    7:12: warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
(Assignee)

Comment 1

6 years ago
Created attachment 575080 [details] [diff] [review]
Patch v1
Assignee: nobody → atulagrwl
Attachment #575080 - Flags: review?(kaie)
(Assignee)

Updated

6 years ago
Whiteboard: [build_warning]
(Assignee)

Comment 2

6 years ago
Created attachment 575086 [details] [diff] [review]
Patch v1.01

Also fixing couple of deprecated warnings like
/mozilla/mozilla-central/security/manager/ssl/src/nsNSSCertTrust.cpp:125:36: warning: ‘__CERTDB_VALID_PEER’ is deprecated (de    clared at ../../../../dist/include/certdb.h:61): CERTDB_VALID_PEER is now CERTDB_TERMINAL_RECORD [-Wdeprecated-declarations]
Attachment #575080 - Attachment is obsolete: true
Attachment #575080 - Flags: review?(kaie)
Attachment #575086 - Flags: review?(kaie)

Updated

6 years ago
Blocks: 187528
(Assignee)

Comment 3

6 years ago
Pinging for code review.

Comment 4

6 years ago
Comment on attachment 575086 [details] [diff] [review]
Patch v1.01

r=kaie

If you cannot check this in yourself, please add keyword checkin-needed

Thanks for the patch
Attachment #575086 - Flags: review?(kaie) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 5

6 years ago
I'm afraid your patch no longer applies, it needs to be updated to latest mozilla-central.
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
Created attachment 599227 [details] [diff] [review]
Patch v1.10

Rebasing the patch over current m-c.
Attachment #575086 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/daceb968bf88
Keywords: checkin-needed
Target Milestone: --- → mozilla13

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/daceb968bf88
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

5 years ago
Duplicate of this bug: 692681
You need to log in before you can comment on or make changes to this bug.