JAWS doesn't announce combobox navigation in collapsed combobox

RESOLVED FIXED in Firefox 10

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({access})

unspecified
mozilla11
x86
Windows 7
access
Points:
---

Firefox Tracking Flags

(firefox10 fixed)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Created attachment 575099 [details] [diff] [review]
patch

regression from bug 673958. JAWS expects focus event for changed option. Similar to Orca. I contacted to FS to check if they can do IE way for Firefox (i.e. based on value change events), that's should be consistent across browsers and ATs (NVDA picks up value change event well). In either way I think we should add a hook for JAWS to keep it working.
Attachment #575099 - Flags: review?(marco.zehe)

Comment 1

6 years ago
Comment on attachment 575099 [details] [diff] [review]
patch

r=me, even though I think this is rather hacky. ;) But at least it will get JAWS working with those comboboxes.
Attachment #575099 - Flags: review?(marco.zehe) → review+
(Assignee)

Comment 2

6 years ago
(In reply to Marco Zehe (:MarcoZ) from comment #1)
> Comment on attachment 575099 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> r=me, even though I think this is rather hacky. ;) But at least it will get
> JAWS working with those comboboxes.

absolutely, in bug 673958 we ended up that we shouldn't fire focus event for options when they aren't visible so I do this for JAWS only. Marco, would you mind to check how other screen readers feel about that like WE or Supernova?
(Assignee)

Comment 3

6 years ago
inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/8914d038bd09

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8914d038bd09
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Comment 5

6 years ago
Comment on attachment 575099 [details] [diff] [review]
patch

need to be ported into Firefox 10 where regression was introduced (bug 673958). The bug prevents JAWS (major screen reader) to work with comboboxes. Patch is trivial, the code is JAWS specific (nobody else is affected).
Attachment #575099 - Flags: approval-mozilla-aurora?

Comment 6

6 years ago
I believe this is responsible for various a11y MozAfterPaint regressions on dev.tree-management:
http://graphs-new.mozilla.org/graph.html#tests=[[113,63,1],[113,63,12],[113,131,1]]&sel=1321910662231.955,1322043257360&displayrange=7&datatype=running
(Assignee)

Comment 7

6 years ago
then it means ::GetModuleHandleW() call is high expensive
(Assignee)

Comment 8

6 years ago
Comment on attachment 575099 [details] [diff] [review]
patch

canceling request until perf problems are figured out
Attachment #575099 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 9

6 years ago
Created attachment 576441 [details] [diff] [review]
patch2

let's see if it helps
Attachment #576441 - Flags: review?(marco.zehe)
Comment on attachment 576441 [details] [diff] [review]
patch2

r=me. Good idea to switch these checks around so the ::getModuleHandle call doesn't get executed each time.
Attachment #576441 - Flags: review?(marco.zehe) → review+
(Assignee)

Comment 11

6 years ago
inbound land (patch2) https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a66776a891
(Assignee)

Comment 12

6 years ago
(In reply to alexander surkov from comment #11)
> inbound land (patch2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a66776a891

yep, it fixes regression: http://graphs-new.mozilla.org/graph.html#tests=[[113,63,1],[113,63,12],[113,131,1]]&sel=1322043767971.9514,1322067320066&displayrange=7&datatype=running
Great, thanks! :-)
https://hg.mozilla.org/mozilla-central/rev/c7a66776a891
(Assignee)

Comment 15

6 years ago
Comment on attachment 576441 [details] [diff] [review]
patch2

see comment #5 (perf regression is fixed)
Attachment #576441 - Flags: approval-mozilla-aurora?
Alex, you might want to put up a unified patch for Aurora that just shows the diffs against the current Aurora code. This patch2 depends on patch1, which is confusing, esp if none of us ends up transplanting the patch in case we get approval. So my recommendation is to make a patch specific to Aurora that only contains the fixed version of the code, and request approval for that.
(Assignee)

Comment 17

6 years ago
Created attachment 576870 [details] [diff] [review]
combined patch
Attachment #576870 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
Attachment #576441 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #576870 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed to Aurora on Alexander's behalf: http://hg.mozilla.org/releases/mozilla-aurora/rev/d36cab2ac025
status-firefox10: --- → fixed
(Assignee)

Comment 19

6 years ago
Thanks, Marco!
Is this something QA can verify?
Whiteboard: [qa?]
(Assignee)

Comment 21

6 years ago
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #20)
> Is this something QA can verify?

yeah, you need JAWS for this though. If you have JAWS running then you should tab into HTML select (combobox) and then arrow down through its options. If JAWS reads them then bug is fixed.
Unfortunately, this is not something I'm set up to test. For now I will mark this qa- in the hopes that someone from the community can help verify this fix.
Whiteboard: [qa?] → [qa-]
You need to log in before you can comment on or make changes to this bug.