703372 - Extension from feature/native-app branch does not install on Windows

Status: VERIFIED INVALID

(Web Apps :: Extension, defect)

Description

[Mohamed Dabbagh]

On Windows, an extension built from the feature/native-app branch does not install in Firefox. An extension built from the develop branch works. I tried with different versions of FF (even modified the install.rdf file) and still the same behavior. This is blocking QA's testing and verification. The error message is:

'Open Web Apps for Firefox could not be installed because Firefox cannot modify the needed file'.

It works on Mac but not on Windows XP/Vista/7. I noticed this problem occurring from the extension built on Monday November 14 and on. You can find the extension builds here: 

http://people.mozilla.com/~mdabbagh/openwebapps/extension/

Steps to Reproduce:
1. git clone http://github.com/mozilla/openwebapps
2. cd openwebapps
3. git checkout feature/native-app
4. make pull
5. make xpi
6. Drag the extension to your Firefox window

Actual Results:
Extension is not installed an error is shown in door-hanger notification

Expected Results:
Extension is installed correctly on Windows.

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

This was caused by paths in the extension that exceed MAX_PATH (260 chars).  This is no longer an issue now that XULRunner is not being packaged with the extension.

Comment 2

[Mohamed Dabbagh]

This seems fixed with an extension built using 'cfx xpi' within the jetpack directory. Tried with Windows XP, Vista and 7. 

However, this bug should not be closed until we can do a 'make xpi' within the openwebapps folder within the feature/native-app branch to build the extension the recommended way. Currently, an error is thrown if a 'make xpi' is done:

make -C addons/jetpack/mac/
make[1]: Entering directory `/home/mdabbagh/build_openwebapps/openwebapps/addons/jetpack/mac'
make[1]: *** No rule to make target `foxlauncher.o', needed by `build'.  Stop.
make[1]: Leaving directory `/home/mdabbagh/build_openwebapps/openwebapps/addons/jetpack/mac'
make: *** [xpi] Error 2

Comment 3

[Mohamed Dabbagh]

This is now invalid as we have switched to testing only from the 'develop' branch and there the extension installs properly. Closing.