Retain the DataSourceSurface in GetThebesSurfaceForDrawTarget

RESOLVED FIXED in Firefox 10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox10 fixed)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 575348 [details] [diff] [review]
Retain the DataSourceSurface

The Quartz Azure backend has the data owned by the DataSourceSurface so we can't drop the DataSourceSurface after creating an image surface around it. This patch keeps the DataSourceSurface around for the lifetime of the gfxASurface.
Attachment #575348 - Flags: review?(bas.schouten)
Comment on attachment 575348 [details] [diff] [review]
Retain the DataSourceSurface

Review of attachment 575348 [details] [diff] [review]:
-----------------------------------------------------------------

This is good.
Attachment #575348 - Flags: review?(bas.schouten) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → jmuizelaar
(Assignee)

Updated

6 years ago
Attachment #575348 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 2

6 years ago
This fixes a possible leak and should be quite safe.

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/2c6e762d9c2a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11

Updated

6 years ago
Attachment #575348 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/3e1324e78c8a
(Assignee)

Updated

6 years ago
status-firefox10: --- → fixed
Is this something QA can verify?
Whiteboard: [qa?]
You need to log in before you can comment on or make changes to this bug.