Closed
Bug 703472
Opened 14 years ago
Closed 14 years ago
Retain the DataSourceSurface in GetThebesSurfaceForDrawTarget
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
| Tracking | Status | |
|---|---|---|
| firefox10 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
(Whiteboard: [qa?])
Attachments
(1 file)
|
1.05 KB,
patch
|
bas.schouten
:
review+
christian
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The Quartz Azure backend has the data owned by the DataSourceSurface so we can't drop the DataSourceSurface after creating an image surface around it. This patch keeps the DataSourceSurface around for the lifetime of the gfxASurface.
Attachment #575348 -
Flags: review?(bas.schouten)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 575348 [details] [diff] [review]
Retain the DataSourceSurface
Review of attachment 575348 [details] [diff] [review]:
-----------------------------------------------------------------
This is good.
Attachment #575348 -
Flags: review?(bas.schouten) → review+
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jmuizelaar
|
|
Assignee | |
Updated•14 years ago
|
Attachment #575348 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 2•14 years ago
|
||
This fixes a possible leak and should be quite safe.
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Attachment #575348 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
status-firefox10:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•