Last Comment Bug 703491 - Silence Nv3DVStream assertion
: Silence Nv3DVStream assertion
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla11
Assigned To: Robert O'Callahan (:roc) (email my personal email if necessary)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-17 19:36 PST by Robert O'Callahan (:roc) (email my personal email if necessary)
Modified: 2012-05-23 00:03 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.00 KB, patch)
2011-11-17 19:37 PST, Robert O'Callahan (:roc) (email my personal email if necessary)
bas: review+
Details | Diff | Splinter Review
part 2: fix bool issues, silence more (1.80 KB, patch)
2011-11-21 13:48 PST, Robert O'Callahan (:roc) (email my personal email if necessary)
no flags Details | Diff | Splinter Review
part 2 v2 (2.53 KB, patch)
2011-11-21 13:54 PST, Robert O'Callahan (:roc) (email my personal email if necessary)
bas: review+
Details | Diff | Splinter Review

Description Robert O'Callahan (:roc) (email my personal email if necessary) 2011-11-17 19:36:11 PST
NS_ASSERTION(rv, "Nv3DVStreaming Nv3DVControl failed!");
fails all the time for me. I don't have the 3D hardware of course. Let's turn it into a warning at best.
Comment 1 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-11-17 19:37:20 PST
Created attachment 575369 [details] [diff] [review]
fix
Comment 2 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-11-20 20:41:16 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b1567ef9a57
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-11-21 05:04:18 PST
So why did this bool suddenly turn into an nsresult?
Comment 4 Matt Brubeck (:mbrubeck) 2011-11-21 09:05:59 PST
https://hg.mozilla.org/mozilla-central/rev/7b1567ef9a57
Comment 5 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-11-21 13:31:55 PST
(In reply to Ms2ger from comment #3)
> So why did this bool suddenly turn into an nsresult?

Yes, that was a mistake. I have a new patch.
Comment 6 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-11-21 13:48:10 PST
Created attachment 575963 [details] [diff] [review]
part 2: fix bool issues, silence more

These are bools not nsresults. Also some of the other assertions are still firing. Silence them.
Comment 7 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-11-21 13:54:08 PST
Created attachment 575966 [details] [diff] [review]
part 2 v2

Fix checks, use NS_WARN_IF_FALSE, use DebugOnly.
Comment 8 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-11-23 15:07:13 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4b3e893fe4
Comment 9 Ed Morley [:emorley] 2011-11-24 08:20:20 PST
https://hg.mozilla.org/mozilla-central/rev/4d4b3e893fe4
Comment 10 Matthew Gregan [:kinetik] 2012-05-23 00:03:53 PDT
I guess nobody noticed that the logic for when to warn was inverted by this change.

Note You need to log in before you can comment on or make changes to this bug.