NS_ASSERTION(rv, "Nv3DVStreaming Nv3DVControl failed!"); fails all the time for me. I don't have the 3D hardware of course. Let's turn it into a warning at best.
Created attachment 575369 [details] [diff] [review] fix
So why did this bool suddenly turn into an nsresult?
(In reply to Ms2ger from comment #3) > So why did this bool suddenly turn into an nsresult? Yes, that was a mistake. I have a new patch.
6 years ago
Created attachment 575963 [details] [diff] [review] part 2: fix bool issues, silence more These are bools not nsresults. Also some of the other assertions are still firing. Silence them.
Created attachment 575966 [details] [diff] [review] part 2 v2 Fix checks, use NS_WARN_IF_FALSE, use DebugOnly.
I guess nobody noticed that the logic for when to warn was inverted by this change.