Silence Nv3DVStream assertion

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla11
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(2 attachments, 1 obsolete attachment)

NS_ASSERTION(rv, "Nv3DVStreaming Nv3DVControl failed!");
fails all the time for me. I don't have the 3D hardware of course. Let's turn it into a warning at best.
Created attachment 575369 [details] [diff] [review]
fix
Assignee: nobody → roc
Attachment #575369 - Flags: review?(bas.schouten)
Attachment #575369 - Flags: review?(bas.schouten) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b1567ef9a57
Whiteboard: [inbound]
So why did this bool suddenly turn into an nsresult?
https://hg.mozilla.org/mozilla-central/rev/7b1567ef9a57
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
(In reply to Ms2ger from comment #3)
> So why did this bool suddenly turn into an nsresult?

Yes, that was a mistake. I have a new patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 575963 [details] [diff] [review]
part 2: fix bool issues, silence more

These are bools not nsresults. Also some of the other assertions are still firing. Silence them.
Attachment #575963 - Flags: review?(bas.schouten)
Created attachment 575966 [details] [diff] [review]
part 2 v2

Fix checks, use NS_WARN_IF_FALSE, use DebugOnly.
Attachment #575963 - Attachment is obsolete: true
Attachment #575963 - Flags: review?(bas.schouten)
Attachment #575966 - Flags: review?(bas.schouten)
Attachment #575966 - Flags: review?(bas.schouten) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4b3e893fe4
Whiteboard: [inbound]

Comment 9

6 years ago
https://hg.mozilla.org/mozilla-central/rev/4d4b3e893fe4
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
I guess nobody noticed that the logic for when to warn was inverted by this change.
You need to log in before you can comment on or make changes to this bug.