703491 - Silence Nv3DVStream assertion

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

NS_ASSERTION(rv, "Nv3DVStreaming Nv3DVControl failed!");
fails all the time for me. I don't have the 3D hardware of course. Let's turn it into a warning at best.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b1567ef9a57

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

So why did this bool suddenly turn into an nsresult?

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/7b1567ef9a57

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Ms2ger from comment #3)
> So why did this bool suddenly turn into an nsresult?

Yes, that was a mistake. I have a new patch.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: part 2: fix bool issues, silence more

These are bools not nsresults. Also some of the other assertions are still firing. Silence them.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: part 2 v2

Fix checks, use NS_WARN_IF_FALSE, use DebugOnly.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4b3e893fe4

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4d4b3e893fe4

Comment 10

[Matthew Gregan [:kinetik]]

I guess nobody noticed that the logic for when to warn was inverted by this change.