Last Comment Bug 703516 - Move GLContext* code out of thebes
: Move GLContext* code out of thebes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Matt Woodrow (:mattwoodrow)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-18 00:08 PST by Matt Woodrow (:mattwoodrow)
Modified: 2012-02-01 13:57 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Move GL code into a separate folder (8.19 KB, patch)
2011-11-18 00:08 PST, Matt Woodrow (:mattwoodrow)
jmuizelaar: review+
Details | Diff | Splinter Review
patch two syntax errors (-pedantic) (974 bytes, patch)
2011-11-19 07:28 PST, Stefan
no flags Details | Diff | Splinter Review

Description Matt Woodrow (:mattwoodrow) 2011-11-18 00:08:13 PST
Created attachment 575405 [details] [diff] [review]
Move GL code into a separate folder

It has no business there.

Attached patch moves our GL code into a separate folder.
Comment 1 Matt Woodrow (:mattwoodrow) 2011-11-18 01:11:58 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/335e8e75eedc
Comment 2 Ed Morley [:emorley] 2011-11-19 05:16:33 PST
https://hg.mozilla.org/mozilla-central/rev/335e8e75eedc
Comment 3 Stefan 2011-11-19 07:28:01 PST
Created attachment 575671 [details] [diff] [review]
patch two syntax errors (-pedantic)
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-11-20 11:24:36 PST
Comment on attachment 575405 [details] [diff] [review]
Move GL code into a separate folder

>--- /dev/null
>+++ b/gfx/gl/Makefile.in
>@@ -0,0 +1,96 @@
>+
>+DEPTH		= ../..
>+topsrcdir	= @top_srcdir@
>+srcdir		= @srcdir@
>+VPATH		= @srcdir@

License headers are not optional. Fix that.
Comment 5 Joe Drew (not getting mail) 2011-11-21 10:43:06 PST
I've filed bug 704210 on that.
Comment 6 :aceman 2011-12-01 11:25:35 PST
Stefan, I will fix those in bug 706610.
Comment 7 Ed Morley [:emorley] 2011-12-03 13:29:55 PST
gfx/gl/Makefile.in was created in the tree by this bug, but was not listed in toolkit/toolkit-makefiles.sh, so I've included it here:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17e8e969fa09

Note You need to log in before you can comment on or make changes to this bug.