Closed Bug 703522 Opened 9 years ago Closed 9 years ago

Simplify focus-restoring code

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Bug 178324 completely rewrote the focus code but we didn't take advantage of it. In particular the focus-restoring code could be much simpler, although parts of bug 509298 help there too.
Attached patch Proposed patchSplinter Review
1 line added, 2 lines changed, 72 lines deleted!
Assignee: nobody → neil
Status: NEW → ASSIGNED
Summary: Simply focus-restoring code → Simplify focus-restoring code
Attachment #575410 - Flags: review?(iann_bugzilla)
Comment on attachment 575410 [details] [diff] [review]
Proposed patch

Does any of the new code need comments to explain it?
Attachment #575410 - Flags: review?(iann_bugzilla) → review+
(In reply to Ian Neal from comment #2)
> (From update of attachment 575410 [details] [diff] [review])
> Does any of the new code need comments to explain it?
Yeah, I should totally restore one of the comments.
Pushed changeset ee9ec0063b73 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 735946
You need to log in before you can comment on or make changes to this bug.