The default bug view has changed. See this FAQ.

#ifdef windows and crash reporter specific parts of browser.js

RESOLVED FIXED in Firefox 13

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
Firefox 13
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
I wrote a script that looks for resource:// uris in the built code and checks whether the corresponding files exist, so as to detect problems with resource://gre/ used where resource:/// was meant. It turns out it also detects "problems" with imports of files that are not installed in every cases.

For instance, in browser.js, a file that is only installed in windows builds is imported, as well as a file that is only installed when the crash reporter is built.

While these are cosmetic issues, it would make my life easier if the patch i'm about to attach would be applied.
(Assignee)

Comment 1

5 years ago
Created attachment 575411 [details] [diff] [review]
#ifdef some windows and crash reporter specific parts of browser.js
(Assignee)

Comment 2

5 years ago
Created attachment 597767 [details] [diff] [review]
#ifdef some windows and crash reporter specific parts of browser.js
(Assignee)

Updated

5 years ago
Attachment #575411 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #597767 - Flags: review?(gavin.sharp)
Attachment #597767 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/86f8ab61e755
https://hg.mozilla.org/mozilla-central/rev/86f8ab61e755
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.