Closed
Bug 703523
Opened 13 years ago
Closed 13 years ago
#ifdef windows and crash reporter specific parts of browser.js
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file, 1 obsolete file)
3.03 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
I wrote a script that looks for resource:// uris in the built code and checks whether the corresponding files exist, so as to detect problems with resource://gre/ used where resource:/// was meant. It turns out it also detects "problems" with imports of files that are not installed in every cases.
For instance, in browser.js, a file that is only installed in windows builds is imported, as well as a file that is only installed when the crash reporter is built.
While these are cosmetic issues, it would make my life easier if the patch i'm about to attach would be applied.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #575411 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Attachment #597767 -
Flags: review?(gavin.sharp)
Updated•13 years ago
|
Attachment #597767 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in
before you can comment on or make changes to this bug.
Description
•