703714 - calling navigator.apps.install with relative url sets app "origin" to "undefined://"

Status: RESOLVED DUPLICATE of bug 745928

(Core :: DOM: Core & HTML, defect, P2)

Description

[Ian Bicking (:ianbicking)]

From https://github.com/mozilla/openwebapps/issues/27

Here's an example:

navigator.apps.install({
  url: "theband.webapp",
  onsuccess: function() {
    alert('OMG');
  },
  onerror: function(wtf) {
    console.log(wtf);
  }

Doing this results in the app manifest being retrieved properly and the app being installed, but once installed, if the user goes to the gear icon in Firefox's browser chrome and selects "Manage Apps", then "View Manifest" for the installed app, the "origin" key of the manifest is set to undefined://.

To work around this, we changed the url key to be an absolute URL.

---

https://developer.mozilla.org/en/OpenWebApps/TheJavaScript_API#Installation_API%28navigator.apps.*%29 specifies that the install URL must be absolute (or preceded by a '/' if the app is from the same origin). It seems like we may not be enforcing the rule, we should make the install function fail in this case.

---

Ah, indeed. We were working off of the less comprehensive doc at https://developer.mozilla.org/en/OpenWebApps/Getting_Started.

Comment 1

[Jason Smith [:jsmith]]

What's the status on this bug? Did this get fixed?

Comment 2

[Ian Bicking (:ianbicking)]

I'm not sure, it would be good to verify.  Given the change of implementation there's a good chance this is no longer an issue.

Comment 3

[Jason Smith [:jsmith]]

David - Can you retest?

Comment 4

[[e-mail] [:onecyrenus]]

Yup, but just to be clearer this is actually a first test, the previous test was against the html / js api.

Comment 5

[Ian Bicking (:ianbicking)]

In the new DOM implementation this results in a MANIFEST_PARSE_ERROR.  I've described this in more detail in another bug.