Closed
Bug 703791
Opened 13 years ago
Closed 13 years ago
IonMonkey: Eager compilation fails on basic/testBranchingUnstableLoopCounter.js [visitToInt32(MIRType_Double)]
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: nbp, Assigned: dvander)
References
Details
Attachments
(1 file)
3.50 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
Bug 701957 enables the eager compilation of basic/testBranchingUnstableLoopCounter.js which is now failing because the oracle does not guess the right type during MIR generation and propagation of the Double type from the "if" inside the loop cause the assumption inside Lowering::visitToInt32 to fail with a non-resumable error. Bug 701957 mutes this error by making the compilation fail in such case. (see Lowering::visitToInt32, MIRType_Double case)
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Comment 1•13 years ago
|
||
This is a bug in type analysis. We could make ToInt32 support doubles, but really we should change the specialization to double.
Assignee: general → dvander
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
Fixing this in type analysis is kind of tricky, and not really valuable if the type oracle is accurate. Besides we might need DoubleToInt32 for other things, so this patch just implements it.
Attachment #576510 -
Flags: review?(sstangl)
Updated•13 years ago
|
Attachment #576510 -
Flags: review?(sstangl) → review+
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/4754cf8753c2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•