The default bug view has changed. See this FAQ.

Remove |ifndef DISABLE_XFORMS_HOOKS| since it's never defined

RESOLVED FIXED in mozilla11

Status

()

Core
Build Config
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 337690 added a few ifndef DISABLE_XFORMS_HOOKS conditionals (http://mxr.mozilla.org/mozilla-central/search?string=DISABLE_XFORMS_HOOKS), but it's never defined (believe it was original intended for embedders to be able to disable, but well...we know the story for embedding right now). 

By removing it, it will mean I can remove one of the extra conditionals that bug 696498 is otherwise going to have to add to toolkit-makefiles.sh to keep parity with accessible/src/Makefile.in.
Created attachment 575678 [details] [diff] [review]
Patch v1
Attachment #575678 - Flags: review?(ted.mielczarek)
Created attachment 575685 [details] [diff] [review]
Patch v2

Slight correction to content/base/public/Makefile.in
Attachment #575678 - Attachment is obsolete: true
Attachment #575678 - Flags: review?(ted.mielczarek)
Attachment #575685 - Flags: review?(ted.mielczarek)
https://tbpl.mozilla.org/?tree=Try&rev=51eba91e1c12
Comment on attachment 575685 [details] [diff] [review]
Patch v2

Review of attachment 575685 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting. I wonder where this got removed?
Attachment #575685 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/89db63eda545
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/89db63eda545
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.