Closed Bug 703889 Opened 8 years ago Closed 8 years ago

Remove |ifndef DISABLE_XFORMS_HOOKS| since it's never defined

Categories

(Firefox Build System :: General, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla11

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 337690 added a few ifndef DISABLE_XFORMS_HOOKS conditionals (http://mxr.mozilla.org/mozilla-central/search?string=DISABLE_XFORMS_HOOKS), but it's never defined (believe it was original intended for embedders to be able to disable, but well...we know the story for embedding right now). 

By removing it, it will mean I can remove one of the extra conditionals that bug 696498 is otherwise going to have to add to toolkit-makefiles.sh to keep parity with accessible/src/Makefile.in.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #575678 - Flags: review?(ted.mielczarek)
Attached patch Patch v2Splinter Review
Slight correction to content/base/public/Makefile.in
Attachment #575678 - Attachment is obsolete: true
Attachment #575678 - Flags: review?(ted.mielczarek)
Attachment #575685 - Flags: review?(ted.mielczarek)
Comment on attachment 575685 [details] [diff] [review]
Patch v2

Review of attachment 575685 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting. I wonder where this got removed?
Attachment #575685 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/89db63eda545
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/89db63eda545
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.